From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27234 invoked by alias); 9 Dec 2014 22:48:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27136 invoked by uid 89); 9 Dec 2014 22:48:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f48.google.com Received: from mail-wg0-f48.google.com (HELO mail-wg0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 09 Dec 2014 22:48:35 +0000 Received: by mail-wg0-f48.google.com with SMTP id y19so2149158wgg.7 for ; Tue, 09 Dec 2014 14:48:32 -0800 (PST) X-Received: by 10.180.82.227 with SMTP id l3mr1258711wiy.0.1418165312790; Tue, 09 Dec 2014 14:48:32 -0800 (PST) Received: from msticlxl57.ims.intel.com (fmdmzpr04-ext.fm.intel.com. [192.55.55.39]) by mx.google.com with ESMTPSA id a14sm15590236wib.22.2014.12.09.14.48.28 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 Dec 2014 14:48:32 -0800 (PST) Date: Tue, 09 Dec 2014 22:48:00 -0000 From: Ilya Verbin To: Richard Biener Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org, Bernd Schmidt , Kirill Yukhin Subject: Re: [PATCH 6/n] OpenMP 4.0 offloading infrastructure: option handling Message-ID: <20141209224821.GB32616@msticlxl57.ims.intel.com> References: <20141011144900.GA16368@msticlxl57.ims.intel.com> <20141128000855.GA32423@msticlxl57.ims.intel.com> <20141207235458.GA43729@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00851.txt.bz2 On 09 Dec 14:59, Richard Biener wrote: > On Mon, 8 Dec 2014, Ilya Verbin wrote: > > Unfortunately, this fix was not general enough. > > There might be cases when mixed object files get into lto-wrapper, ie some of > > them contain only LTO sections, some contain only offload sections, and some > > contain both. But when lto-wrapper will pass all these files to recompilation, > > the compiler might crash (it depends on the order of input files), since in > > read_cgraph_and_symbols it expects that *all* input files contain IR section of > > given type. > > This patch splits input objects from argv into lto_argv and offload_argv, so > > that all files in arrays contain corresponding IR. > > Similarly, in lto-plugin, it was bad idea to add objects, which contain offload > > IR without LTO, to claimed_files, since this may corrupt a resolution file. > > > > Tested on various combinations of files with/without -flto and with/without > > offload, using trunk ld and gold, also tested on ld without plugin support. > > Bootstrap and make check passed on x86_64-linux and i686-linux. Ok for trunk? > > Did you check that bootstrap-lto still works? Ok if so. Yes, bootstrap-lto passed. Committed revision 218543. Thanks, -- Ilya