From: Jan Hubicka <hubicka@ucw.cz>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de
Subject: Re: Fix streaming of target optimization/option nodes
Date: Mon, 15 Dec 2014 08:29:00 -0000 [thread overview]
Message-ID: <20141215074919.GA16783@kam.mff.cuni.cz> (raw)
In-Reply-To: <20141215062619.GB11373@kam.mff.cuni.cz>
Hi,
actually this patch break fortran, I get streaming error in:
lto1: internal compiler error: in streamer_get_pickled_tree
apparently picking error_mark_node for variable constructor results in reading integer_type...
Honza
> Hi,
> the testcase in PR ipa/61324 fails because it is compiled with -O0 and linked with -O2.
> This should not matter anymore if there wasn't the following problem in streamer that
> makes us to merge all default nodes across units.
>
> Bootstrapped/regtested x86_64-linux, plan to commit it after more testing finishes (Firefox)
>
> Honza
>
> PR ipa/61324
> * tree-streamer.c (preload_common_nodes): Do not ocnsider optimizatoin
> nad target_option nodes as common nodes; they depend on flags.
>
> Index: tree-streamer.c
> ===================================================================
> --- tree-streamer.c (revision 218726)
> +++ tree-streamer.c (working copy)
> @@ -324,7 +324,14 @@ preload_common_nodes (struct streamer_tr
> /* Skip boolean type and constants, they are frontend dependent. */
> if (i != TI_BOOLEAN_TYPE
> && i != TI_BOOLEAN_FALSE
> - && i != TI_BOOLEAN_TRUE)
> + && i != TI_BOOLEAN_TRUE
> + /* Skip optimization and target option nodes; they depend on flags. */
> + && i != TI_OPTIMIZATION_DEFAULT
> + && i != TI_OPTIMIZATION_CURRENT
> + && i != TI_TARGET_OPTION_DEFAULT
> + && i != TI_TARGET_OPTION_CURRENT
> + && i != TI_CURRENT_TARGET_PRAGMA
> + && i != TI_CURRENT_OPTIMIZE_PRAGMA)
> record_common_node (cache, global_trees[i]);
> }
>
next prev parent reply other threads:[~2014-12-15 7:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 6:34 Jan Hubicka
2014-12-15 8:29 ` Jan Hubicka [this message]
2014-12-15 8:41 ` Richard Biener
2014-12-15 17:12 ` Jan Hubicka
2014-12-15 21:57 ` Jan Hubicka
2014-12-15 22:37 ` Jan Hubicka
2014-12-22 11:05 ` Thomas Schwinge
2015-01-05 16:59 ` H.J. Lu
2014-12-16 9:36 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215074919.GA16783@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).