From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3706 invoked by alias); 18 Dec 2014 16:44:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3677 invoked by uid 89); 18 Dec 2014 16:44:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Dec 2014 16:44:01 +0000 Received: from tsaunders-iceball.corp.tor1.mozilla.com (unknown [66.207.208.102]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id E6FFFC135 for ; Thu, 18 Dec 2014 16:43:58 +0000 (UTC) Date: Thu, 18 Dec 2014 17:00:00 -0000 From: Trevor Saunders To: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/2] [C++] pr31397 - implement -Wsuggest-override Message-ID: <20141218164114.GA18197@tsaunders-iceball.corp.tor1.mozilla.com> References: <1417069734-23041-1-git-send-email-tsaunders@mozilla.com> <1417069734-23041-2-git-send-email-tsaunders@mozilla.com> <5491F3DB.2000102@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5491F3DB.2000102@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2014-12/txt/msg01551.txt.bz2 On Wed, Dec 17, 2014 at 04:21:31PM -0500, Jason Merrill wrote: > On 11/27/2014 01:28 AM, tsaunders@mozilla.com wrote: > >+ if (warn_override && DECL_VIRTUAL_P (decl) && !DECL_OVERRIDE_P (decl) > > Why check DECL_VIRTUAL_P here? I think it was to avoid warning when decl is hiding a non virtual method on the parent class, but I guess that won't happen anyway? so I'll remove it. Trev > > >+ warning_at(DECL_SOURCE_LOCATION (decl), OPT_Wsuggest_override, > > Space before the (. > > Jason >