From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6893 invoked by alias); 26 Dec 2014 19:15:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6879 invoked by uid 89); 26 Dec 2014 19:15:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f173.google.com Received: from mail-ig0-f173.google.com (HELO mail-ig0-f173.google.com) (209.85.213.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 26 Dec 2014 19:15:35 +0000 Received: by mail-ig0-f173.google.com with SMTP id r2so9080722igi.0 for ; Fri, 26 Dec 2014 11:15:33 -0800 (PST) X-Received: by 10.107.131.133 with SMTP id n5mr39849183ioi.30.1419621333019; Fri, 26 Dec 2014 11:15:33 -0800 (PST) Received: from msticlxl57.ims.intel.com (fmdmzpr04-ext.fm.intel.com. [192.55.55.39]) by mx.google.com with ESMTPSA id e3sm14357806iod.0.2014.12.26.11.15.29 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Dec 2014 11:15:32 -0800 (PST) Date: Fri, 26 Dec 2014 20:53:00 -0000 From: Ilya Verbin To: Thomas Schwinge Cc: Jakub Jelinek , Kirill Yukhin , Andrey Turetskiy , gcc Subject: Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing Message-ID: <20141226191524.GB35839@msticlxl57.ims.intel.com> References: <20141021171323.GA47586@msticlxl57.ims.intel.com> <20141030114001.GA34120@msticlxl57.ims.intel.com> <87tx0t0yh5.fsf@kepler.schwinge.homeip.net> <87oaqvzz0n.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87oaqvzz0n.fsf@kepler.schwinge.homeip.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg01878.txt.bz2 On 22 Dec 12:48, Thomas Schwinge wrote: > What is the reason for adding paths if $tgt_dir is empty? (I mean, if > properly installed and $tgt_dir empty, this should just work, because > that's what a user will be doing, so why does the libgomp testsuite have > to do differently?) The case for empty $tgt_dir is required when offload compiler is installed, but host compiler isn't. > These paths will (basically) point to GCC's > configured --prefix=[...] -- which may not actually match where the > installed offloading compilers are to be found, for example, in the > common case that DESTDIR is used with make install. And, isn't it that > GCC by default will already be looking into "$prefix" installation > directories, or is this solving an actual problem for you? If not, is it > then OK to remove the cases for empty $tgt_dir? If DESTDIR is used, then $tgt_dir can not be empty, otherwise during the build of host compiler the host's part of MIC plugin for libgomp will not find target's part, which is built along with target compiler. > Here is a patch to correctly match intelmic in $offload_targets; OK to > commit, I assume? I suppose I'm the first one to ever do build-tree > testing? (Jakub?) > > --- libgomp/testsuite/lib/libgomp.exp > +++ libgomp/testsuite/lib/libgomp.exp > @@ -115,8 +115,7 @@ proc libgomp_init { args } { > > # Add liboffloadmic build directory in LD_LIBRARY_PATH to support > # non-fallback testing for Intel MIC targets > - if { [string match "*-intelmic-*" $offload_targets] > - || [string match "*-intelmicemul-*" $offload_targets] } { > + if { [string match "*,intelmic,*" ",$offload_targets,"] } { > append always_ld_library_path ":${blddir}/../liboffloadmic/.libs" > append always_ld_library_path ":${blddir}/../liboffloadmic/plugin/.libs" > # libstdc++ is required by liboffloadmic OK, thanks. I verified this case some time ago, but missed when it started failing, since tests just become UNSUPPORTED or PASSED with host fallback, rather than FAILing. > Here is a patch to fix 32-bit x86 Intel MIC offloading; OK to commit, I > assume? > > $ find -name liboffloadmic_target.so.5 > ./install/offload-x86_64-intelmicemul-linux-gnu/lib64/liboffloadmic_target.so.5 > ./install/offload-x86_64-intelmicemul-linux-gnu/lib32/liboffloadmic_target.so.5 > ./build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/liboffloadmic/.libs/liboffloadmic_target.so.5 > ./build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/liboffloadmic/.libs/liboffloadmic_target.so.5 > > --- libgomp/configure.ac > +++ libgomp/configure.ac > @@ -304,7 +304,7 @@ if test x"$enable_offload_targets" != x; then > fi > if test x"$tgt_dir" != x; then > offload_additional_options="$offload_additional_options -B$tgt_dir/libexec/gcc/\$(target_alias)/\$(gcc_version) -B$tgt_dir/bin" > - offload_additional_lib_paths="$offload_additional_lib_paths:$tgt_dir/lib64:$tgt_dir/lib" > + offload_additional_lib_paths="$offload_additional_lib_paths:$tgt_dir/lib64:$tgt_dir/lib:$tgt_dir/lib32" > else > offload_additional_options="$offload_additional_options -B\$(libexecdir)/gcc/\$(target_alias)/\$(gcc_version) -B\$(bindir)" > offload_additional_lib_paths="$offload_additional_lib_paths:$toolexeclibdir" OK, thanks. -- Ilya