From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15347 invoked by alias); 29 Dec 2014 18:46:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15338 invoked by uid 89); 29 Dec 2014 18:46:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 29 Dec 2014 18:46:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBTIkkB2006839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 29 Dec 2014 13:46:46 -0500 Received: from tucnak.zalov.cz (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBTIkiWM029829 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 29 Dec 2014 13:46:46 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id sBTIkgxO001130; Mon, 29 Dec 2014 19:46:43 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id sBTIkfZs001129; Mon, 29 Dec 2014 19:46:41 +0100 Date: Mon, 29 Dec 2014 20:03:00 -0000 From: Jakub Jelinek To: David Abdurachmanov Cc: Dmitry Vyukov , Konstantin Serebryany , GCC Patches , Dodji Seketeli , Marek Polacek , "H.J. Lu" , Yuri Gribov , Alexey Samsonov Subject: Re: libsanitizer merge from upstream r221802 Message-ID: <20141229184641.GP1667@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20141113091614.GB5026@tucnak.redhat.com> <71E9E6B2-2D35-4F25-997A-086EC1005423@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71E9E6B2-2D35-4F25-997A-086EC1005423@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg01939.txt.bz2 On Mon, Dec 29, 2014 at 07:36:42PM +0100, David Abdurachmanov wrote: > I believe this is breaking bootstrap on aarch64-linux-gnu with kernels <=3.15, > 3.16 and above are fine. > > __kernel_old_{gid,uid}_t were changed in 3.16 from unsigned int to unsigned > short. <=3.15 kernel will trigger static asserts in libsanitizer while > compiling GCC. > > I created PR: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64435 (includes all > the details). > > Attaching a patch with resolved issues on F19 + 3.12 kernel (also bootstrapped > in QEMU with F21 rootfs + 3.17 kernel) on aarch64-linux-gnu. That looks very much wrong, ABI can't depend on what kernel headers you are compiling against. So, better would be just to ifdef out the check and always use 16-bit __kernel_old_*_t on aarch64. Are the getresuid16/getresgid16/getgroups16/setgroups16 syscalls wired at all on aarch64? If not, then supposedly the sanitizer_common_syscalls.inc stuff for these syscalls should be ifdefed out on aarch64 (or any other arch that doesn't have those syscalls). Jakub