public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: John David Anglin <dave.anglin@bell.net>
Cc: Jeff Law <law@redhat.com>,
	Richard Biener <richard.guenther@gmail.com>,
	       "H.J. Lu" <hjl.tools@gmail.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c
Date: Mon, 05 Jan 2015 21:24:00 -0000	[thread overview]
Message-ID: <20150105212357.GY1667@tucnak.redhat.com> (raw)
In-Reply-To: <BLU436-SMTP16492009098D2670451691E97580@phx.gbl>

On Mon, Jan 05, 2015 at 03:16:46PM -0500, John David Anglin wrote:
> I think there may be one situation after reload that's not handled
> by the above.  frame_read is only used for const calls.  What about
> the situation where we have a non const sibcall and the frame pointer
> isn't eliminated?

After reload DSE is run after threading prologues/epilogues, end
the prologue/epilogue sequences usually contain wild reads, e.g.
(mem:BLK (scratch)) in some insn etc.
Do you have some particular testcase in mind?

That said, DSE after reload is much more limited than the DSE before reload,
so is less important, so perhaps even
  if ((HARD_FRAME_POINTER_IS_ARG_POINTER || reload_completed)
      && SIBLING_CALL_P (insn))
    {
      add_wild_read (bb_info);                                                                                                                 
      return;                                                                                                                                  
    }
might be good enough.

	Jakub

  reply	other threads:[~2015-01-05 21:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-31 14:31 H.J. Lu
2015-01-03 17:35 ` John David Anglin
2015-01-03 19:48   ` H.J. Lu
2015-01-03 20:10     ` John David Anglin
2015-01-03 20:18       ` H.J. Lu
2015-01-03 20:58         ` John David Anglin
2015-01-03 21:48           ` H.J. Lu
2015-01-04 11:37             ` Richard Biener
2015-01-04 14:57               ` H.J. Lu
2015-01-04 17:16                 ` Richard Biener
2015-01-05 14:19                   ` Jeff Law
2015-01-05 18:51                     ` Jakub Jelinek
2015-01-05 20:17                       ` John David Anglin
2015-01-05 21:24                         ` Jakub Jelinek [this message]
2015-01-05 21:31                           ` Jakub Jelinek
2015-01-06 14:08                             ` [PATCH] Fix up DSE - PR middle-end/64388, target/55023 Jakub Jelinek
2015-01-06 17:06                               ` John David Anglin
2015-01-06 19:12                                 ` Jakub Jelinek
2015-01-08 21:25                               ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105212357.GY1667@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=dave.anglin@bell.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=law@redhat.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).