public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Tim Shen <timshen@google.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex
Date: Fri, 09 Jan 2015 00:42:00 -0000	[thread overview]
Message-ID: <20150109004246.GN3360@redhat.com> (raw)
In-Reply-To: <CAG4ZjN=kJsqeiD98MxA+rqCX0W9gBs-zRsss2p6q65-PPUVp-g@mail.gmail.com>

On 08/01/15 11:44 -0800, Tim Shen wrote:
>On Wed, Jan 7, 2015 at 4:39 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
>> No blank line here in the ChangeLog.
>
>Done.
>
>> This is swapping iterators, which can be user-defined types, so it
>> should support finding a swap function by ADL, i.e.
>
>Done.
>
>> Also, there should be a new test, since apparently we don't have any
>> test that tries to call match_results::swap(match_results&).
>
>Done.

Thanks - OK for trunk and 4.9.

      reply	other threads:[~2015-01-09  0:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07  5:03 Tim Shen
2015-01-07 12:39 ` Jonathan Wakely
2015-01-08 19:44   ` Tim Shen
2015-01-09  0:42     ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150109004246.GN3360@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=timshen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).