From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27996 invoked by alias); 15 Jan 2015 17:53:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27921 invoked by uid 89); 15 Jan 2015 17:53:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f173.google.com Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 15 Jan 2015 17:53:54 +0000 Received: by mail-wi0-f173.google.com with SMTP id hi2so13982219wib.0 for ; Thu, 15 Jan 2015 09:53:51 -0800 (PST) X-Received: by 10.181.8.193 with SMTP id dm1mr27294382wid.55.1421344431128; Thu, 15 Jan 2015 09:53:51 -0800 (PST) Received: from msticlxl57.ims.intel.com (fmdmzpr02-ext.fm.intel.com. [192.55.55.37]) by mx.google.com with ESMTPSA id fc6sm23648703wib.12.2015.01.15.09.53.48 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Jan 2015 09:53:50 -0800 (PST) Date: Thu, 15 Jan 2015 18:02:00 -0000 From: Ilya Verbin To: Mike Stump Cc: gcc-patches@gcc.gnu.org, Kirill Yukhin Subject: Re: [PATCH] Fix PR testsuite/64605 Message-ID: <20150115175342.GC5706@msticlxl57.ims.intel.com> References: <20150115161437.GB5706@msticlxl57.ims.intel.com> <6C9D809A-201B-4918-81DB-BFCCF1FA93E3@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6C9D809A-201B-4918-81DB-BFCCF1FA93E3@comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg01235.txt.bz2 On 15 Jan 09:40, Mike Stump wrote: > On Jan 15, 2015, at 8:14 AM, Ilya Verbin wrote: > > The problem is that gcc-dg.exp calls check_effective_target_lto, which calls > > libatomic_target_compile. Therefore gcc-dg.exp should be loaded only after the > > definition of libatomic_target_compile. > > > However, a similar exp file in other tree (libitm/testsuite/lib/libitm.exp) > > doesn't contain any explicit 'load_gcc_lib gcc-dg.exp' at all, but it loads > > gcc-dg.exp implicitly. So I'm not sure whether this patch is correct. > > So, can you try the itm version of this? If that works, Ok. If I just remove 'load_gcc_lib gcc-dg.exp' from libatomic.exp, like this is done in libitm.exp, it will not work: $ make check-target-libatomic ... ERROR: (DejaGnu) proc "gcc-dg-test-1 libatomic_target_compile ../../../../gcc/libatomic/testsuite/libatomic.c/atomic-compare-exchange-1.c run { -g}" does not exist. Note that gcc-dg-test-1 is defined in gcc-dg.exp, so it's somehow automatically loaded for libitm and other libs, but non loaded for libatomic. -- Ilya