From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32113 invoked by alias); 17 Jan 2015 00:34:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32078 invoked by uid 89); 17 Jan 2015 00:34:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 4 recipients X-HELO: mail-we0-f178.google.com Received: from mail-we0-f178.google.com (HELO mail-we0-f178.google.com) (74.125.82.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 17 Jan 2015 00:34:26 +0000 Received: by mail-we0-f178.google.com with SMTP id p10so22847238wes.9; Fri, 16 Jan 2015 16:34:23 -0800 (PST) X-Received: by 10.181.8.193 with SMTP id dm1mr10986161wid.55.1421454863912; Fri, 16 Jan 2015 16:34:23 -0800 (PST) Received: from msticlxl57.ims.intel.com (fmdmzpr02-ext.fm.intel.com. [192.55.55.37]) by mx.google.com with ESMTPSA id uq1sm7974683wjc.14.2015.01.16.16.34.19 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Jan 2015 16:34:23 -0800 (PST) Date: Sat, 17 Jan 2015 01:23:00 -0000 From: Ilya Verbin To: Jack Howarth Cc: Thomas Schwinge , jakub@gcc.gnu.org, GCC Patches , howarth@bromo.med.uc.edu, Dominique =?iso-8859-1?Q?d'Humi=E8res?= , Andrey Turetskiy , bernds@gcc.gnu.org, kyukhin@gcc.gnu.org Subject: Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch) Message-ID: <20150117003413.GD48380@msticlxl57.ims.intel.com> References: <87egqvu77s.fsf@schwinge.name> <87r3uuzcqg.fsf@kepler.schwinge.homeip.net> <20150116224038.GA48380@msticlxl57.ims.intel.com> <20150116233038.GC48380@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg01503.txt.bz2 On 16 Jan 19:23, Jack Howarth wrote: > As I read https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625#c3, the > requirement for __OFFLOAD_TABLE__ was not longer present and the > residual usages of it just had to be removed. The weak symbol on > darwin is fragile and seems to trip up on the existing code which > produces undefined symbols for ___OFFLOAD_TABLE__... > > # nm e.50.1.o | grep OFF > U ___OFFLOAD_TABLE__ > > rather than > > $ nm e.50.1.o | grep OFF > w __OFFLOAD_TABLE__ > > for all of the test cases. I believe that the initial patch, which removes get_offload_symbol_decl, will fix this. -- Ilya