public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Janus Weil <janus@gcc.gnu.org>
Cc: Andreas Schwab <schwab@suse.de>, gfortran <fortran@gcc.gnu.org>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran, OOP] PR 64230: [4.9/5 Regression] Invalid memory reference in a compiler-generated finalizer for allocatable component
Date: Tue, 27 Jan 2015 19:27:00 -0000	[thread overview]
Message-ID: <20150127182338.GL1746@tucnak.redhat.com> (raw)
In-Reply-To: <CAKwh3qgUY9HhQMKdmk1VrFQB7WXQtjUOvE9JDMdps3z_p-=ojQ@mail.gmail.com>

On Tue, Jan 27, 2015 at 07:20:10PM +0100, Janus Weil wrote:
> 2015-01-27 10:30 GMT+01:00 Jakub Jelinek <jakub@redhat.com>:
> > Yeah, if you want to add ubsan tests, you need to add gfortran.dg/ubsan/
> > directory and hack up ubsan.exp in there
> 
> Thanks for the remark, I was suspecting something like that. However,
> for this case it's not really worth the hassle. In fact the test case
> does not really need the sanitizer and should also work without it. So
> I'll just remove the -fsanitize option:
> 
> Index: gcc/testsuite/gfortran.dg/class_allocate_18.f90
> ===================================================================
> --- gcc/testsuite/gfortran.dg/class_allocate_18.f90    (Revision 220180)
> +++ gcc/testsuite/gfortran.dg/class_allocate_18.f90    (Arbeitskopie)
> @@ -1,5 +1,4 @@
>  ! { dg-do run }
> -! { dg-options "-fsanitize=undefined" }
>  !
>  ! PR 64230: [4.9/5 Regression] Invalid memory reference in a
> compiler-generated finalizer for allocatable component
>  !

LGTM.

	Jakub

  reply	other threads:[~2015-01-27 18:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 15:05 Janus Weil
2015-01-24 10:49 ` Janus Weil
2015-01-24 20:12 ` Tobias Burnus
2015-01-26 17:05   ` Janus Weil
2015-01-26 22:20     ` Paul Richard Thomas
2015-01-26 23:57       ` Janus Weil
2015-01-27  8:10         ` Paul Richard Thomas
2015-01-27  9:47 ` Andreas Schwab
2015-01-27 10:48   ` Jakub Jelinek
2015-01-27 19:21     ` Janus Weil
2015-01-27 19:27       ` Jakub Jelinek [this message]
2015-01-27 20:36         ` Janus Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150127182338.GL1746@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=janus@gcc.gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).