From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15334 invoked by alias); 29 Jan 2015 14:56:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15281 invoked by uid 89); 29 Jan 2015 14:56:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 29 Jan 2015 14:56:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0TEuWK0007941 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 29 Jan 2015 09:56:32 -0500 Received: from tucnak.zalov.cz (ovpn-116-98.ams2.redhat.com [10.36.116.98]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0TEuUNf014366 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 29 Jan 2015 09:56:31 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t0TEuTBx031717; Thu, 29 Jan 2015 15:56:29 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t0TEuSPc031716; Thu, 29 Jan 2015 15:56:28 +0100 Date: Thu, 29 Jan 2015 16:23:00 -0000 From: Jakub Jelinek To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" , Jeff Law Subject: Re: [PATCH][PR target/15184] Fix for direct byte access on x86 Message-ID: <20150129145628.GK1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150129144710.GJ1746@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg02622.txt.bz2 On Thu, Jan 29, 2015 at 03:54:34PM +0100, Uros Bizjak wrote: > On Thu, Jan 29, 2015 at 3:47 PM, Jakub Jelinek wrote: > > >> > So here's the updated patch which handles all 4 testcases from the PR as well as a couple of my own. > >> > >> @@ -0,0 +1,33 @@ > >> +/* PR 15184 first two tests, plus two addition ones. */ > >> +/* { dg-do compile } */ > >> +/* { dg-options "-O2 -m32 -march=pentiumpro" } */ > >> > >> No, we don't want -m32 in dg-options. Please write this part as: > >> > >> /* { dg-do compile { target ia32 } } */ > >> /* { dg-options "-O2 -march=pentiumpro" } */ > > > > Or > > /* { dg-do compile } */ > > /* { dg-options "-O2" } */ > > /* { dg-additional-options "-march=pentiumpro" { target ia32 } } */ > > if there is nothing ia32 specific on the testcase, just that you want > > to use that -march option if you are compiling it as 32-bit. > > In this case, you will need to add -mregparm=3 to > dg-additional-options to avoid "attribute ... ignored" awarning. There > are some examples in dg.target/i386/ testsuite directory. Ah, then better limit that to just ia32 in dg-do. Jakub