From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 895 invoked by alias); 29 Jan 2015 18:26:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 829 invoked by uid 89); 29 Jan 2015 18:26:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 29 Jan 2015 18:26:51 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0TIQlQa006824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 29 Jan 2015 13:26:48 -0500 Received: from tucnak.zalov.cz (ovpn-116-98.ams2.redhat.com [10.36.116.98]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0TIQjYJ011833 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 29 Jan 2015 13:26:46 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t0TIQhhI002782; Thu, 29 Jan 2015 19:26:44 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t0TIQfts002781; Thu, 29 Jan 2015 19:26:41 +0100 Date: Thu, 29 Jan 2015 19:39:00 -0000 From: Jakub Jelinek To: Matthias Klose Cc: "H.J. Lu" , Caroline Tice , Patrick Wollgast , Kai Tietz , Benjamin De Kosnik , "jwakely@redhat.com >> Jonathan Wakely" , gcc-patches , "libstdc++@gcc.gnu.org" Subject: Re: [Ping] Port of VTV for Cygwin and MinGW Message-ID: <20150129182641.GP1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <54B77230.6070704@rub.de> <54B83638.7080509@rub.de> <54C8C89C.1000104@rub.de> <54CA737A.5060102@ubuntu.com> <54CA767F.9040102@ubuntu.com> <54CA78F1.1020204@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54CA78F1.1020204@ubuntu.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg02647.txt.bz2 On Thu, Jan 29, 2015 at 07:16:17PM +0100, Matthias Klose wrote: > On 01/29/2015 07:12 PM, H.J. Lu wrote: > > On Thu, Jan 29, 2015 at 10:05 AM, Matthias Klose wrote: > >> that fixes the build failure. ok to commit? > >> > >> 2015-01-29 Matthias Klose > >> > >> * acinclude.m4 (GLIBCXX_ENABLE_VTABLE_VERIFY): Define VTV_CYGMIN > >> unconditionally. > >> * configure: Regenerate. > >> > > > > This is wrong. You are checking vtv_cygmin before it is defined. > > my bad, somebody should obviously build both variants ... now testing this variant. Even with this patch vtv_cygmin is uninitialized. It will be likely empty string, unless somebody has vtv_cygmin in the environment, but it is better to initialize it, see the patch I've posted. > --- acinclude.m4 (revision 220257) > +++ acinclude.m4 (working copy) > @@ -2320,8 +2320,6 @@ > AC_MSG_CHECKING([for vtable verify support]) > AC_MSG_RESULT([$enable_vtable_verify]) > > - AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes) > - > if test $enable_vtable_verify = yes; then > case ${target_os} in > cygwin*|mingw32*) > @@ -2341,6 +2339,8 @@ > VTV_CXXLINKFLAGS= > fi > > + AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes) > + > AC_SUBST(VTV_CXXFLAGS) > AC_SUBST(VTV_PCH_CXXFLAGS) > AC_SUBST(VTV_CXXLINKFLAGS) > Jakub