From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-390827-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 10515 invoked by alias); 29 Jan 2015 18:30:26 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 10338 invoked by uid 89); 29 Jan 2015 18:30:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 29 Jan 2015 18:30:13 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0TIUBut016636	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Thu, 29 Jan 2015 13:30:11 -0500
Received: from tucnak.zalov.cz (ovpn-116-98.ams2.redhat.com [10.36.116.98])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0TIUAbB002913	(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO);	Thu, 29 Jan 2015 13:30:11 -0500
Received: from tucnak.zalov.cz (localhost [127.0.0.1])	by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t0TIU72c002797;	Thu, 29 Jan 2015 19:30:07 +0100
Received: (from jakub@localhost)	by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t0TIU5bq002796;	Thu, 29 Jan 2015 19:30:05 +0100
Date: Thu, 29 Jan 2015 20:01:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Matthias Klose <doko@ubuntu.com>, Caroline Tice <cmtice@google.com>,        Patrick Wollgast <patrick.wollgast@rub.de>,        Kai Tietz <ktietz70@googlemail.com>, Benjamin De Kosnik <bkoz@gnu.org>,        "jwakely@redhat.com >> Jonathan Wakely" <jwakely@redhat.com>,        gcc-patches <gcc-patches@gcc.gnu.org>,        "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
Message-ID: <20150129183005.GQ1746@tucnak.redhat.com>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <CAKOQZ8wCM4+0guCsqzeFZjgUu-Y81NX9RbGhV-i7xz8_OVuMyQ@mail.gmail.com> <54B83638.7080509@rub.de> <54C8C89C.1000104@rub.de> <CABtf2+R2kY+tv7Wk+rtnU6s55RbMmSgejqeWn11rqb7PHA-COA@mail.gmail.com> <54CA737A.5060102@ubuntu.com> <54CA767F.9040102@ubuntu.com> <CAMe9rOohc7imtMstqRBJCnbUsms9DNDgYO=GcYmjao9b0c9Szg@mail.gmail.com> <54CA78F1.1020204@ubuntu.com> <20150129182641.GP1746@tucnak.redhat.com> <CAMe9rOrAGT7pq9v-NfJbfEKmPOk7Jv01yAHdpTfwWbM4cxu6ug@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMe9rOrAGT7pq9v-NfJbfEKmPOk7Jv01yAHdpTfwWbM4cxu6ug@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg02649.txt.bz2

On Thu, Jan 29, 2015 at 10:28:17AM -0800, H.J. Lu wrote:
> >> --- acinclude.m4        (revision 220257)
> >> +++ acinclude.m4        (working copy)
> >> @@ -2320,8 +2320,6 @@
> >>    AC_MSG_CHECKING([for vtable verify support])
> >>    AC_MSG_RESULT([$enable_vtable_verify])
> >>
> >> -  AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
> >> -
> >>    if test $enable_vtable_verify = yes; then
> >>      case ${target_os} in
> >>        cygwin*|mingw32*)
> >> @@ -2341,6 +2339,8 @@
> >>      VTV_CXXLINKFLAGS=
> >>    fi
> >>
> >> +  AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
> >> +
> >
> 
> Or we can just do
> 
> AM_CONDITIONAL(VTV_CYGMIN, test x$vtv_cygmin = xyes)

Or that, but that is not what you've checked in.
Some shells will be upset about test $vtv_cygmin = yes when
$vtv_cygmin expands to empty string.

	Jakub