From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16659 invoked by alias); 30 Jan 2015 10:13:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16619 invoked by uid 89); 30 Jan 2015 10:13:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 30 Jan 2015 10:13:27 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0UADPI5009673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 30 Jan 2015 05:13:25 -0500 Received: from tucnak.zalov.cz (ovpn-116-98.ams2.redhat.com [10.36.116.98]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0UADNpP010861 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 30 Jan 2015 05:13:24 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t0UADLaL004353; Fri, 30 Jan 2015 11:13:21 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t0UADJQE004352; Fri, 30 Jan 2015 11:13:19 +0100 Date: Fri, 30 Jan 2015 11:21:00 -0000 From: Jakub Jelinek To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" , Jeff Law , Dominique Dhumieres Subject: Re: [PATCH][PR target/15184] Fix for direct byte access on x86 Message-ID: <20150130101319.GZ1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <54CB20CA.3070709@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg02707.txt.bz2 On Fri, Jan 30, 2015 at 11:07:45AM +0100, Uros Bizjak wrote: > --- gcc.target/i386/pr15184-1.c (revision 220273) > +++ gcc.target/i386/pr15184-1.c (working copy) > @@ -1,11 +1,10 @@ > /* PR 15184 first two tests, plus two addition ones. */ > -/* { dg-do compile } */ > -/* { dg-options "-O2 -m32 -march=pentiumpro" } */ > +/* { dg-do compile { target ia32 } } */ > +/* { dg-options "-O2 -march=pentiumpro" } */ > > -#define regparm __attribute__((__regparm__(3))) > +#define regparm __attribute__((__regparm__(1))) > > extern unsigned int x; > -extern unsigned short y; > > void regparm f0(unsigned char c) > { > @@ -29,5 +28,5 @@ > > /* Each function should compile down to a byte move from > the input register into x, possibly at an offset within x. */ > -/* { dg-final { scan-assembler-times "\tmovb\t%al, x" 4 } } */ > +/* { dg-final { scan-assembler-times "movb\[ \\t\]+%al" 4 } } */ Shouldn't that better be movb\[^\n\r\]+%al, so that it doesn't fail with -masm=intel ? Jakub