From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-390981-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 1295 invoked by alias); 31 Jan 2015 11:49:29 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 1281 invoked by uid 89); 31 Jan 2015 11:49:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 31 Jan 2015 11:49:28 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0VBnG9X011722	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Sat, 31 Jan 2015 06:49:16 -0500
Received: from redhat.com (ovpn-116-59.ams2.redhat.com [10.36.116.59])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0VBnBpm026868	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);	Sat, 31 Jan 2015 06:49:14 -0500
Date: Sat, 31 Jan 2015 15:45:00 -0000
From: Marek Polacek <polacek@redhat.com>
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: Chen Gang S <gang.chen@sunrus.com.cn>,        Andreas Schwab <schwab@linux-m68k.org>,        Ian Lance Taylor <ian@airs.com>, Jakub Jelinek <jakub@redhat.com>,        "walt@tilera.com" <walt@tilera.com>, Jeff Law <law@redhat.com>,        gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.
Message-ID: <20150131114911.GK4074@redhat.com>
References: <54CC7085.1080805@sunrus.com.cn> <m24mr749gs.fsf@linux-m68k.org> <54CCA7D8.7010702@sunrus.com.cn> <CAAgBjM=X0xRpuo8RNqSBptV1QjGOMMjcaf-cR_A-AS_qJ3p5FQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAgBjM=X0xRpuo8RNqSBptV1QjGOMMjcaf-cR_A-AS_qJ3p5FQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SW-Source: 2015-01/txt/msg02803.txt.bz2

On Sat, Jan 31, 2015 at 05:13:53PM +0530, Prathamesh Kulkarni wrote:
> On 31 January 2015 at 15:30, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
> > On 1/31/15 16:53, Andreas Schwab wrote:
> >> Chen Gang S <gang.chen@sunrus.com.cn> writes:
> >>
> >>>      * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use braces
> >>>      instead of macro's empty body to avoid xgcc warnings.
> The ChangeLog entry should be fixed to reflect it's an empty loop now.
> something like:
> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use empty do-while
> loop as macro body to avoid xgcc warnings.

And since CL entries should describe what, not why, the "to avoid..."
part is redundant.

	Marek