From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22154 invoked by alias); 18 Feb 2015 12:01:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22081 invoked by uid 89); 18 Feb 2015 12:01:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Feb 2015 12:01:00 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1IC0tnV016942 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 Feb 2015 07:00:56 -0500 Received: from tucnak.zalov.cz (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1IC0rn9031296 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 18 Feb 2015 07:00:55 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t1IC0qRV006506; Wed, 18 Feb 2015 13:00:52 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t1IC0pgw006505; Wed, 18 Feb 2015 13:00:51 +0100 Date: Wed, 18 Feb 2015 12:01:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: Ilya Verbin , gcc-patches@gcc.gnu.org, Kirill Yukhin , Andrey Turetskiy Subject: Re: [PATCH 1/4] Add mkoffload for Intel MIC Message-ID: <20150218120051.GJ1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20141021171323.GA47586@msticlxl57.ims.intel.com> <20141021171602.GB47586@msticlxl57.ims.intel.com> <20141022082103.GH10376@tucnak.redhat.com> <20141022185701.GA21398@msticlxl57.ims.intel.com> <87k2zfe8ze.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87k2zfe8ze.fsf@kepler.schwinge.homeip.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg01091.txt.bz2 On Wed, Feb 18, 2015 at 12:48:21PM +0100, Thomas Schwinge wrote: > > --- /dev/null > > +++ b/gcc/config/i386/t-intelmic > > @@ -0,0 +1,9 @@ > > +mkoffload.o: $(srcdir)/config/i386/intelmic-mkoffload.c | insn-modes.h > > + $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \ > > + -I$(srcdir)/../libgomp \ > > + -DDEFAULT_REAL_TARGET_MACHINE=\"$(real_target_noncanonical)\" \ > > + -DDEFAULT_TARGET_MACHINE=\"$(target_noncanonical)\" \ > > + $< $(OUTPUT_OPTION) > > + > > +mkoffload$(exeext): mkoffload.o collect-utils.o libcommon-target.a $(LIBIBERTY) $(LIBDEPS) > > + $(COMPILER) -o $@ mkoffload.o collect-utils.o libcommon-target.a $(LIBIBERTY) $(LIBS) > > What is the rationale for the insn-modes.h order-only prerequisites for > mkoffload.o? Is this simply to get past the build issue which, for > example, Jakub also reported for the nvptx mkoffload, > > (»missing mkoffload.o dependencies, patch attached«), or is there a > better rationale for adding (only) this one (indirect) dependency, > instead of listing all of the (real) dependencies? (After all, we do > want the mkoffload executables to be rebuilt if one of their dependencies > is updated.) (I have not yet tried to figure out how to do that.) Perhaps if we try to ALL_HOST_OBJS += mkoffload.o everything would be handled fine? I mean, in that case it should have automatic dependency on all the $(generated_files) and additionally automatic dependencies for mkoffload.o would be sourced in from .deps/mkoffload.Po Jakub