From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31079 invoked by alias); 19 Feb 2015 12:51:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31065 invoked by uid 89); 19 Feb 2015 12:51:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 19 Feb 2015 12:51:29 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1JCpRfO011468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Feb 2015 07:51:27 -0500 Received: from tucnak.zalov.cz (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1JCpPqc008707 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 19 Feb 2015 07:51:26 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t1JCpNxl003935; Thu, 19 Feb 2015 13:51:24 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t1JCpMSV003934; Thu, 19 Feb 2015 13:51:22 +0100 Date: Thu, 19 Feb 2015 12:59:00 -0000 From: Jakub Jelinek To: Richard Biener Cc: Tom de Vries , GCC Patches , Michael Matz Subject: Re: [PATCH][4/5] Handle internal_fn in operand_equal_p Message-ID: <20150219125122.GF1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <54E5BB06.2080102@mentor.com> <54E5C403.7050606@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg01188.txt.bz2 On Thu, Feb 19, 2015 at 01:44:46PM +0100, Richard Biener wrote: > I'd call it a bug though, and we do have internal fns in > generic already thus the issue is latent (with ubsan at least). > > Which means ok for trunk now. But the patch should better handle the internal calls right. I.e. return 0 only if only one, not both CALL_EXPR_FNs are NULL, or if both are NULL and CALL_EXPR_IFN is different, or if call_expr_nargs is different. Jakub