* [PATCH] Fix hoist-register-pressure testcases for -m31 on s390x
@ 2015-02-19 17:28 Andreas Krebbel
2015-02-20 19:02 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Krebbel @ 2015-02-19 17:28 UTC (permalink / raw)
To: gcc-patches
Hi,
the attached patch makes the hoist-register-pressure testcases to work
with -m31 on 64 bit.
Ok to apply?
Bye,
-Andreas-
2015-02-19 Andreas Krebbel <Andreas.Krebbel@de.ibm.com>
* gcc.dg/hoist-register-pressure-1.c: Make S/390 target check work
with -m31 on 64 bit.
* gcc.dg/hoist-register-pressure-2.c: Likewise.
* gcc.dg/hoist-register-pressure-3.c: Likewise.
diff --git a/gcc/testsuite/gcc.dg/hoist-register-pressure-1.c b/gcc/testsuite/gcc.dg/hoist-register-pressure-1.c
index 4aabcb7..995711a 100644
--- a/gcc/testsuite/gcc.dg/hoist-register-pressure-1.c
+++ b/gcc/testsuite/gcc.dg/hoist-register-pressure-1.c
@@ -3,7 +3,7 @@
be assigned without clobbering cc. For a PLUS rtx on S/390 this
requires a load address instruction which is fine on 64 bit but
cannot be used on 31 bit since it does a 31 bit add only. */
-/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { { ! s390-*-* } && nonpic } } } } */
+/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { { !s390*-*-* || lp64 } && nonpic } } } } */
/* { dg-final { cleanup-rtl-dump "hoist" } } */
#define BUF 100
diff --git a/gcc/testsuite/gcc.dg/hoist-register-pressure-2.c b/gcc/testsuite/gcc.dg/hoist-register-pressure-2.c
index f1c927e..b5a4a99 100644
--- a/gcc/testsuite/gcc.dg/hoist-register-pressure-2.c
+++ b/gcc/testsuite/gcc.dg/hoist-register-pressure-2.c
@@ -3,7 +3,7 @@
be assigned without clobbering cc. For a PLUS rtx on S/390 this
requires a load address instruction which is fine on 64 bit but
cannot be used on 31 bit since it does a 31 bit add only. */
-/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { ! s390-*-* } } } } */
+/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { !s390*-*-* || lp64 } } } } */
/* { dg-final { cleanup-rtl-dump "hoist" } } */
#define BUF 100
diff --git a/gcc/testsuite/gcc.dg/hoist-register-pressure-3.c b/gcc/testsuite/gcc.dg/hoist-register-pressure-3.c
index 24abaa6..6237dc6 100644
--- a/gcc/testsuite/gcc.dg/hoist-register-pressure-3.c
+++ b/gcc/testsuite/gcc.dg/hoist-register-pressure-3.c
@@ -3,7 +3,7 @@
be assigned without clobbering cc. For a PLUS rtx on S/390 this
requires a load address instruction which is fine on 64 bit but
cannot be used on 31 bit since it does a 31 bit add only. */
-/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { ! s390-*-* } } } } */
+/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { !s390*-*-* || lp64 } } } } */
/* { dg-final { cleanup-rtl-dump "hoist" } } */
#define BUF 100
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix hoist-register-pressure testcases for -m31 on s390x
2015-02-19 17:28 [PATCH] Fix hoist-register-pressure testcases for -m31 on s390x Andreas Krebbel
@ 2015-02-20 19:02 ` Jeff Law
2015-02-20 19:35 ` Mike Stump
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2015-02-20 19:02 UTC (permalink / raw)
To: Andreas Krebbel, gcc-patches
On 02/19/15 10:27, Andreas Krebbel wrote:
> Hi,
>
> the attached patch makes the hoist-register-pressure testcases to work
> with -m31 on 64 bit.
>
> Ok to apply?
>
> Bye,
>
> -Andreas-
>
>
> 2015-02-19 Andreas Krebbel <Andreas.Krebbel@de.ibm.com>
>
> * gcc.dg/hoist-register-pressure-1.c: Make S/390 target check work
> with -m31 on 64 bit.
> * gcc.dg/hoist-register-pressure-2.c: Likewise.
> * gcc.dg/hoist-register-pressure-3.c: Likewise.
Yes. ISTM that this kind of patch (twiddling target conditionals in the
testsuite) should be OK for a target maintainer to apply without
requesting approval, even though it's not in the backend proper.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix hoist-register-pressure testcases for -m31 on s390x
2015-02-20 19:02 ` Jeff Law
@ 2015-02-20 19:35 ` Mike Stump
2015-04-06 12:15 ` [wwwdocs] svnwrite.html PATCH for " Gerald Pfeifer
0 siblings, 1 reply; 4+ messages in thread
From: Mike Stump @ 2015-02-20 19:35 UTC (permalink / raw)
To: Jeff Law; +Cc: Andreas Krebbel, gcc-patches
On Feb 20, 2015, at 10:53 AM, Jeff Law <law@redhat.com> wrote:
> On 02/19/15 10:27, Andreas Krebbel wrote:
>>
>> the attached patch makes the hoist-register-pressure testcases to work
>> with -m31 on 64 bit.
>>
>> Ok to apply?
>>
>> Bye,
>>
>> -Andreas-
>>
>>
>> 2015-02-19 Andreas Krebbel <Andreas.Krebbel@de.ibm.com>
>>
>> * gcc.dg/hoist-register-pressure-1.c: Make S/390 target check work
>> with -m31 on 64 bit.
>> * gcc.dg/hoist-register-pressure-2.c: Likewise.
>> * gcc.dg/hoist-register-pressure-3.c: Likewise.
> Yes. ISTM that this kind of patch (twiddling target conditionals in the testsuite) should be OK for a target maintainer to apply without requesting approval, even though it's not in the backend proper.
Yes, that’s right.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [wwwdocs] svnwrite.html PATCH for Re: [PATCH] Fix hoist-register-pressure testcases for -m31 on s390x
2015-02-20 19:35 ` Mike Stump
@ 2015-04-06 12:15 ` Gerald Pfeifer
0 siblings, 0 replies; 4+ messages in thread
From: Gerald Pfeifer @ 2015-04-06 12:15 UTC (permalink / raw)
To: Mike Stump; +Cc: Jeff Law, Andreas Krebbel, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]
On Fri, 20 Feb 2015, Mike Stump wrote:
>> Yes. ISTM that this kind of patch (twiddling target conditionals in
>> the testsuite) should be OK for a target maintainer to apply without
>> requesting approval, even though it's not in the backend proper.
> Yes, thatÂ’s right.
I tried to capture this in our documentation now and applied the
patch below. Let me know if you'd like to see this tweaked.
Gerald
Index: svnwrite.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v
retrieving revision 1.33
diff -u -r1.33 svnwrite.html
--- svnwrite.html 14 Jul 2014 09:45:48 -0000 1.33
+++ svnwrite.html 6 Apr 2015 12:13:12 -0000
@@ -107,9 +107,10 @@
<dd><p>This is for people who have primary responsibility for ports,
front ends, or other specific aspects of the compiler. These folks
are allowed to make changes to areas they maintain and related
- documentation, web pages, and test cases without approval from
- anyone else, and approve other people's changes in those areas. They
- must get approval for changes elsewhere in the compiler.</p>
+ documentation, web pages, and test cases (and target conditionals)
+ without approval from anyone else, and approve other people's changes
+ in those areas.
+ They must get approval for changes elsewhere in the compiler.</p>
<p>Maintainers of a port maintain the relevant files in
<code>gcc/config</code>, documentation, web pages, and test cases
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-06 12:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-19 17:28 [PATCH] Fix hoist-register-pressure testcases for -m31 on s390x Andreas Krebbel
2015-02-20 19:02 ` Jeff Law
2015-02-20 19:35 ` Mike Stump
2015-04-06 12:15 ` [wwwdocs] svnwrite.html PATCH for " Gerald Pfeifer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).