From: Jakub Jelinek <jakub@redhat.com>
To: Tom de Vries <Tom_deVries@mentor.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][testsuite] Abort on failure in gcc.dg/pr30957-1.c
Date: Fri, 20 Feb 2015 09:47:00 -0000 [thread overview]
Message-ID: <20150220094236.GV1746@tucnak.redhat.com> (raw)
In-Reply-To: <54E6FDA2.5030408@mentor.com>
On Fri, Feb 20, 2015 at 10:25:54AM +0100, Tom de Vries wrote:
> this patch reverses the abort logic in pr30957-1.c, such that it aborts on
> failure rather than on success.
That sounds really weird. From the description it looks like it is a known bug
that we don't return -0.0.
If 0.0 is the right return value instead, I'd the test should be written as
if (__builtin_copysignf (1.0, foo (0.0 / -5.0, 10)) != 1.0)
abort ();
to make it clear you are expecting positive 0.
Jakub
next prev parent reply other threads:[~2015-02-20 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 9:27 Tom de Vries
2015-02-20 9:47 ` Jakub Jelinek [this message]
2015-02-20 13:04 ` Tom de Vries
2015-02-20 13:22 ` Jakub Jelinek
2015-02-20 19:23 ` Mike Stump
2015-02-22 12:42 ` Tom de Vries
2015-02-20 18:22 ` Mike Stump
2015-02-20 19:27 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220094236.GV1746@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=Tom_deVries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).