* [PATCH] Fix up pr44194-1.c testcase (PR testsuite/64158)
@ 2015-02-20 14:46 Jakub Jelinek
2015-02-20 16:41 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2015-02-20 14:46 UTC (permalink / raw)
To: Rainer Orth, Mike Stump; +Cc: gcc-patches
Hi!
As written in the PR, this testcase is supposed to be blacklisted on
(lp64) powerpc*-*-linux* unless powerpc_elfv2 and also on nvptx,
but apparently neither of those blacklistings really work.
tcl or dejagnu or the target expression parser are unhappy about the
missing {}s, it doesn't like cond1 && cond2 && cond3 but wants
{ { cond1 && cond2 } && cond3 } instead (fixes the powerpc* blacklisting)
and was missing another pair of {}s around the whole thing (that should fix
nvptx).
Regtested on x86_64-linux and i686-linux, additionally tested with
replacing the various targets in the expression with x86_64-*-* instead
and checking the test became UNSUPPORTED as it should. Ok for trunk?
2015-02-20 Jakub Jelinek <jakub@redhat.com>
PR testsuite/64158
* gcc.dg/pr44194-1.c: Add two extra {} pairs to fix up powerpc*-*-linux*
and nvptx-*-* blacklisting.
--- gcc/testsuite/gcc.dg/pr44194-1.c.jj 2014-11-11 00:06:05.000000000 +0100
+++ gcc/testsuite/gcc.dg/pr44194-1.c 2015-02-20 12:45:55.419301827 +0100
@@ -1,4 +1,4 @@
-/* { dg-do compile { target { { { { { { { { i?86-*-* x86_64-*-* } && x32 } || lp64 } && { ! s390*-*-* } } && { ! hppa*64*-*-* } } && { ! alpha*-*-* } } && { { ! powerpc*-*-linux* } || powerpc_elfv2 } && { ! nvptx-*-* } } } } } */
+/* { dg-do compile { target { { { { { { { { { { i?86-*-* x86_64-*-* } && x32 } || lp64 } && { ! s390*-*-* } } && { ! hppa*64*-*-* } } && { ! alpha*-*-* } } && { { ! powerpc*-*-linux* } || powerpc_elfv2 } } && { ! nvptx-*-* } } } } } } */
/* { dg-options "-O2 -fdump-rtl-dse1 -fdump-rtl-final" } */
/* Restrict to 64-bit targets since 32-bit targets usually return small
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix up pr44194-1.c testcase (PR testsuite/64158)
2015-02-20 14:46 [PATCH] Fix up pr44194-1.c testcase (PR testsuite/64158) Jakub Jelinek
@ 2015-02-20 16:41 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2015-02-20 16:41 UTC (permalink / raw)
To: Jakub Jelinek, Rainer Orth, Mike Stump; +Cc: gcc-patches
On 02/20/15 07:43, Jakub Jelinek wrote:
> Hi!
>
> As written in the PR, this testcase is supposed to be blacklisted on
> (lp64) powerpc*-*-linux* unless powerpc_elfv2 and also on nvptx,
> but apparently neither of those blacklistings really work.
> tcl or dejagnu or the target expression parser are unhappy about the
> missing {}s, it doesn't like cond1 && cond2 && cond3 but wants
> { { cond1 && cond2 } && cond3 } instead (fixes the powerpc* blacklisting)
> and was missing another pair of {}s around the whole thing (that should fix
> nvptx).
>
> Regtested on x86_64-linux and i686-linux, additionally tested with
> replacing the various targets in the expression with x86_64-*-* instead
> and checking the test became UNSUPPORTED as it should. Ok for trunk?
>
> 2015-02-20 Jakub Jelinek <jakub@redhat.com>
>
> PR testsuite/64158
> * gcc.dg/pr44194-1.c: Add two extra {} pairs to fix up powerpc*-*-linux*
> and nvptx-*-* blacklisting.
Got to love the unholy trinity of dejagnu, expect & tcl...
OK.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-20 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-20 14:46 [PATCH] Fix up pr44194-1.c testcase (PR testsuite/64158) Jakub Jelinek
2015-02-20 16:41 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).