[PATCH] Add sibcall-{9,10}.c testcases

[PATCH] Add sibcall-{9,10}.c testcases

[Jakub Jelinek]

Hi!

As mentioned in PR63892, with the addition of ICF the sibcall-{3,4}.c tests
no longer test what they meant to test.  This patch duplicates the tests
and adds a volatile var bump in just one of the functions so that ICF can't
be performed and the tests really test sibcalls rather than say tail
recursion.

Regtested on x86_64-linux and i686-linux, ok for trunk?

2015-02-20  Jakub Jelinek  <jakub@redhat.com>

	* gcc.dg/sibcall-9.c: New test.
	* gcc.dg/sibcall-10.c: New test.

--- gcc/testsuite/gcc.dg/sibcall-9.c.jj	2015-02-20 13:18:23.235665924 +0100
+++ gcc/testsuite/gcc.dg/sibcall-9.c	2015-02-20 13:19:44.830335968 +0100
@@ -0,0 +1,82 @@
+/* Simple check that sibling calls are performed from a
+   void non-leaf-function taking one int argument calling a function which
+   is about the same as itself.
+
+   Copyright (C) 2002 Free Software Foundation Inc.
+   Contributed by Hans-Peter Nilsson  <hp@bitrange.com>  */
+
+/* { dg-do run { xfail { { cris-*-* crisv32-*-* h8300-*-* hppa*64*-*-* m32r-*-* mcore-*-* mn10300-*-* msp430*-*-* nds32*-*-* xstormy16-*-* v850*-*-* vax-*-* xtensa*-*-* } || { arm*-*-* && { ! arm32 } } } } } */
+/* -mlongcall disables sibcall patterns.  */
+/* { dg-skip-if "" { powerpc*-*-* } { "-mlongcall" } { "" } } */
+/* { dg-options "-O2 -foptimize-sibling-calls" } */
+
+/* The option -foptimize-sibling-calls is the default, but serves as
+   marker.  This test is xfailed on targets without sibcall patterns
+   (except targets where the test does not work due to the return address
+   not saved on the regular stack).  */
+
+extern void abort (void);
+extern void exit (int);
+
+/* Sibcalls are not supported in MIPS16 mode, which has direct calls but
+   not direct jumps.  */
+#ifdef __mips
+#define ATTR __attribute__((nomips16))
+#else
+#define ATTR
+#endif
+
+static ATTR void recurser_void1 (int);
+static ATTR void recurser_void2 (int);
+extern void track (int);
+volatile int v;
+
+int main ()
+{
+  recurser_void1 (0);
+  if (v != 5)
+    abort ();
+  exit (0);
+}
+
+/* The functions should get the same stack-frame, and best way to make it
+   reasonably sure is to make them have the same contents (regarding the
+   n tests).  */
+
+static void __attribute__((noinline)) ATTR
+recurser_void1 (int n)
+{
+  if (n == 0 || n == 7 || n == 8)
+    track (n);
+
+  if (n == 10)
+    return;
+
+  recurser_void2 (n + 1);
+}
+
+static void __attribute__((noinline)) ATTR
+recurser_void2 (int n)
+{
+  if (n == 0 || n == 7 || n == 8)
+    track (n);
+
+  if (n == 10)
+    return;
+
+  v++;
+  recurser_void1 (n + 1);
+}
+
+void *trackpoint;
+
+void __attribute__ ((noinline))
+track (int n)
+{
+  char stackpos[1];
+
+  if (n == 0)
+    trackpoint = stackpos;
+  else if ((n != 7 && n != 8) || trackpoint != stackpos)
+    abort ();
+}
--- gcc/testsuite/gcc.dg/sibcall-10.c.jj	2015-02-20 13:19:51.170232631 +0100
+++ gcc/testsuite/gcc.dg/sibcall-10.c	2015-02-20 13:20:50.570264437 +0100
@@ -0,0 +1,83 @@
+/* Simple check that sibling calls are performed from a
+   void non-leaf-function taking no arguments calling a function which
+   is about the same as itself.
+
+   Copyright (C) 2002 Free Software Foundation Inc.
+   Contributed by Hans-Peter Nilsson  <hp@bitrange.com>  */
+
+/* { dg-do run { xfail { { cris-*-* crisv32-*-* h8300-*-* hppa*64*-*-* m32r-*-* mcore-*-* mn10300-*-* msp430*-*-* nds32*-*-* xstormy16-*-* v850*-*-* vax-*-* xtensa*-*-* } || { arm*-*-* && { ! arm32 } } } } } */
+/* -mlongcall disables sibcall patterns.  */
+/* { dg-skip-if "" { powerpc*-*-* } { "-mlongcall" } { "" } } */
+/* { dg-options "-O2 -foptimize-sibling-calls" } */
+
+/* The option -foptimize-sibling-calls is the default, but serves as
+   marker.  This test is xfailed on targets without sibcall patterns
+   (except targets where the test does not work due to the return address
+   not saved on the regular stack).  */
+
+extern void abort (void);
+extern void exit (int);
+
+/* Sibcalls are not supported in MIPS16 mode, which has direct calls but
+   not direct jumps.  */
+#ifdef __mips
+#define ATTR __attribute__((nomips16))
+#else
+#define ATTR
+#endif
+
+static ATTR void recurser_void1 (void);
+static ATTR void recurser_void2 (void);
+extern void track (void);
+volatile int v;
+
+int n = 0;
+int main ()
+{
+  recurser_void1 ();
+  if (v != 5)
+    abort ();
+  exit (0);
+}
+
+/* The functions should get the same stack-frame, and best way to make it
+   reasonably sure is to make them have the same contents (regarding the
+   n tests).  */
+
+static void __attribute__((noinline)) ATTR
+recurser_void1 (void)
+{
+  if (n == 0 || n == 7 || n == 8)
+    track ();
+
+  if (n == 10)
+    return;
+  n++;
+  recurser_void2 ();
+}
+
+static void __attribute__((noinline)) ATTR
+recurser_void2 (void)
+{
+  if (n == 0 || n == 7 || n == 8)
+    track ();
+
+  if (n == 10)
+    return;
+  n++;
+  v++;
+  recurser_void1 ();
+}
+
+void *trackpoint;
+
+void __attribute__ ((noinline))
+track ()
+{
+  char stackpos[1];
+
+  if (n == 0)
+    trackpoint = stackpos;
+  else if ((n != 7 && n != 8) || trackpoint != stackpos)
+    abort ();
+}

	Jakub

Re: [PATCH] Add sibcall-{9,10}.c testcases

[Jeff Law]

On 02/20/15 07:45, Jakub Jelinek wrote:
> Hi!
>
> As mentioned in PR63892, with the addition of ICF the sibcall-{3,4}.c tests
> no longer test what they meant to test.  This patch duplicates the tests
> and adds a volatile var bump in just one of the functions so that ICF can't
> be performed and the tests really test sibcalls rather than say tail
> recursion.
>
> Regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2015-02-20  Jakub Jelinek  <jakub@redhat.com>
>
> 	* gcc.dg/sibcall-9.c: New test.
> 	* gcc.dg/sibcall-10.c: New test.
OK.
Jeff