From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105043 invoked by alias); 26 Feb 2015 10:46:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 104934 invoked by uid 89); 26 Feb 2015 10:46:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Feb 2015 10:46:09 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1QAk57c021330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 26 Feb 2015 05:46:06 -0500 Received: from tucnak.zalov.cz (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1QAk3Tc026708 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 26 Feb 2015 05:46:04 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t1QAk1rd021592; Thu, 26 Feb 2015 11:46:01 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t1QAk0iG021591; Thu, 26 Feb 2015 11:46:00 +0100 Date: Thu, 26 Feb 2015 10:53:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: Bernd Schmidt , GCC Patches Subject: Re: var-tracking vs. pseudo registers (was: Option overriding in the offloading code path) Message-ID: <20150226104600.GC1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <5454CDF1.3070307@codesourcery.com> <87fvacld85.fsf@kepler.schwinge.homeip.net> <87a90klcyb.fsf@kepler.schwinge.homeip.net> <87mw429tfn.fsf@kepler.schwinge.homeip.net> <20150225170054.GV1746@tucnak.redhat.com> <87vbipge85.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87vbipge85.fsf@schwinge.name> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg01588.txt.bz2 On Thu, Feb 26, 2015 at 11:27:06AM +0100, Thomas Schwinge wrote: > Is this not the right way to skip it, or, Bernd, is this because we're > not yet handling some debug stuff in nvptx? (I tested that > > does not help with that.) The following does make it work (that is, > resolve the ICEs), but that feels a bit too much ;-) of a hack: > > --- gcc/var-tracking.c > +++ gcc/var-tracking.c > @@ -10305,7 +10322,8 @@ variable_tracking_main_1 (void) > { > bool success; > > - if (flag_var_tracking_assignments < 0) > + if (flag_var_tracking_assignments < 0 > + || targetm.no_register_allocation) > { > delete_debug_insns (); > return 0; No, IMHO that is the right fix, not a hack. But of course would deserve a comment. Plus of course you can also just override flag_var_tracking_assignments in the nvptx override option hook, and perhaps in tree-streamer-in.c clear flag_var_tracking_assignments in the OPTIMIZATION_NODE too (or just add a hook for that, as I said before). Jakub