From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78317 invoked by alias); 6 Mar 2015 10:51:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 78251 invoked by uid 89); 6 Mar 2015 10:51:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 06 Mar 2015 10:51:50 +0000 Received: from arm.com (e106375-lin.cambridge.arm.com [10.2.206.37]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t26ApkNP031163; Fri, 6 Mar 2015 10:51:46 GMT Date: Fri, 06 Mar 2015 10:51:00 -0000 From: James Greenhalgh To: "pinskia@gmail.com" Cc: Christophe Lyon , Jakub Jelinek , GCC Patches , Alan Lawrence Subject: Re: [PATCH/AARCH64] Fix 64893: ICE with vget_lane_u32 with C++ front-end at -O0 Message-ID: <20150306105146.GA6045@arm.com> References: <20150203073744.GV1746@tucnak.redhat.com> <20150306094534.GA16569@arm.com> <7037901D-EA2D-4B65-A8C3-794998C922A2@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: <7037901D-EA2D-4B65-A8C3-794998C922A2@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00349.txt.bz2 --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 2224 On Fri, Mar 06, 2015 at 10:03:46AM +0000, pinskia@gmail.com wrote: > > On Mar 6, 2015, at 1:45 AM, James Greenhalgh wrote: > > > >> On Thu, Feb 12, 2015 at 03:37:33PM +0000, Christophe Lyon wrote: > >>> On 8 February 2015 at 03:24, Andrew Pinski wrote: > >>> On Fri, Feb 6, 2015 at 5:02 PM, Andrew Pinski wrote: > >>> PR target/64893 > >>> * config/aarch64/aarch64-builtins.c (aarch64_init_simd_builtins): > >>> Change the first argument type to size_type_node and add another > >>> size_type_node. > >>> (aarch64_simd_expand_builtin): Handle the new argument to > >>> AARCH64_SIMD_BUILTIN_LANE_CHECK and don't ICE but rather > >>> print an out when the first two arguments are not > >>> nonzero integer constants. > >>> * config/aarch64/arm_neon.h (__AARCH64_LANE_CHECK): > >>> Pass the sizeof directly to __builtin_aarch64_im_lane_boundsi. > >>> > >>> testsuite/ChangeLog: > >>> > >>> * c-c++-common/torture/aarch64-vect-lane-1.c: New testcase. > >>> * c-c++-common/torture/aarch64-vect-lane-2.c: New testcase. > >> In case you haven't noticed, aarch64-vect-lane-2.c FAILs when compiled at > >> -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects > >> but PASSes with the other optimization levels. > > > > Hi Andrew, > > > > Did you get a chance to look at this? Given the way that your error > > checking works, the test probably just needs a dg-skip-if -flto > > directive. Did you intend to come back to this and make it fail earlier > > than link time with -flto? > > > > If I don't hear otherwise, I'll propose the patch adding dg-skip-if on > > Monday. > > Yes that is the correct approach as I see it. Thanks for the confirmation. In the end I settled on XFAILing (It would be nice to catch the error early enough that one day this test PASSes) the test rather than skipping it. I committed the attached patch as obvious as r221233. Thanks, James --- 2015-03-06 James Greenhalgh * c-c++-common/torture/aarch64-vect-lane-2.c: XFAIL for LTO compiles using the linker plugin. --OgqxwSJOaUobr8KG Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="xfail-aarch64-vect-lane.patch" Content-length: 937 Index: gcc/testsuite/ChangeLog =================================================================== --- gcc/testsuite/ChangeLog (revision 221232) +++ gcc/testsuite/ChangeLog (working copy) @@ -1,3 +1,8 @@ +2015-03-06 James Greenhalgh + + * c-c++-common/torture/aarch64-vect-lane-2.c: XFAIL for LTO + compiles using the linker plugin. + 2015-03-06 Eric Botcazou * g++.dg/other/dump-ada-spec-3.C: Remove include and adjust. Index: gcc/testsuite/c-c++-common/torture/aarch64-vect-lane-2.c =================================================================== --- gcc/testsuite/c-c++-common/torture/aarch64-vect-lane-2.c (revision 221232) +++ gcc/testsuite/c-c++-common/torture/aarch64-vect-lane-2.c (working copy) @@ -1,4 +1,5 @@ // { dg-do compile { target "aarch64*-*-*" } } +// { dg-xfail-if "" { *-*-* } { "-flto -fuse-linker-plugin" } { "" } } int search_line_fast (void) { --OgqxwSJOaUobr8KG--