public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Alex Velenko <alex.velenko@arm.com>
Cc: gcc-patches@gcc.gnu.org, Marcus.Shawcroft@arm.com
Subject: Re: [PATCH] [RTL] Relax CSE check to set REG_EQUAL notes.
Date: Fri, 06 Mar 2015 12:24:00 -0000	[thread overview]
Message-ID: <20150306122437.GA31245@gate.crashing.org> (raw)
In-Reply-To: <1425467354-6018-1-git-send-email-alex.velenko@arm.com>

On Wed, Mar 04, 2015 at 11:09:14AM +0000, Alex Velenko wrote:
> I prefer adding notes in CSE instead of adding additional checks in Jump2
> and, if any, other passes, as I think it is more uniform solution and allows
> single point fix. Downside is having more notes.

The other downside is that every other RTL producer will have to add
these notes as well, or passes that look at this info will have to look
at the insns themselves anyway.  Not a good trade-off in my opinion.

Just add a simple helper function to do these checks (isn't there one
already)?


Segher

  reply	other threads:[~2015-03-06 12:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 11:09 Alex Velenko
2015-03-06 12:24 ` Segher Boessenkool [this message]
2015-03-09  9:54 ` Steven Bosscher
2015-03-09 17:40   ` Jeff Law
2015-04-10  9:14     ` Alex Velenko
2015-04-24  1:17       ` Jeff Law
2015-04-24 12:52         ` Alex Velenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150306122437.GA31245@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=Marcus.Shawcroft@arm.com \
    --cc=alex.velenko@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).