From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122447 invoked by alias); 9 Mar 2015 11:30:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 122431 invoked by uid 89); 9 Mar 2015 11:30:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 09 Mar 2015 11:30:15 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t29BUBGh012596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 9 Mar 2015 07:30:12 -0400 Received: from tucnak.zalov.cz (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t29BU99N023854 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 9 Mar 2015 07:30:10 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t29BU7Qs022256; Mon, 9 Mar 2015 12:30:08 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t29BU5XF022255; Mon, 9 Mar 2015 12:30:05 +0100 Date: Mon, 09 Mar 2015 11:30:00 -0000 From: Jakub Jelinek To: gcc-patches@gcc.gnu.org, Andreas Krebbel Subject: Re: [PATCH] S390: Hotpatching fixes. Message-ID: <20150309113005.GP1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150305124019.GA6266@linux.vnet.ibm.com> <20150309112221.GA4801@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150309112221.GA4801@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00456.txt.bz2 On Mon, Mar 09, 2015 at 12:22:21PM +0100, Dominik Vogt wrote: > @@ -5308,34 +5309,14 @@ s390_asm_output_function_label (FILE *asm_out_file, const char *fname, > stored directly before the label without crossing a cacheline > boundary. All this is necessary to make sure the trampoline code can > be changed atomically. */ > + function_alignment = MAX (8, DECL_ALIGN (decl) / BITS_PER_UNIT); > + if (! DECL_USER_ALIGN (decl)) > + function_alignment = MAX (function_alignment, > + (unsigned int) align_functions); Wrong formatting. function_alignment should be only 2 columns to the right from if. > +(define_insn "nop_6_byte" > + [(unspec_volatile [(const_int 0)] UNSPECV_NOP_6_BYTE)] > + "" Shouldn't this use "TARGET_ZARCH" condition? BTW, have you tried say: __attribute__((hotpatch (0, 6))) void foo (void) { __builtin_unreachable (); } ? Have you verified there never are real instructions before NOTE_INSN_FUNCTION_BEG? Jakub