From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] Improve PR44563
Date: Tue, 10 Mar 2015 05:12:00 -0000 [thread overview]
Message-ID: <20150310051250.GA59707@kam.mff.cuni.cz> (raw)
In-Reply-To: <alpine.LSU.2.11.1503091610470.10796@zhemvz.fhfr.qr>
>
> This reduces the time spent in cgraph call-site hash by providing
> inline version of htab_hash_pointer.
>
> Bootstrap / regtest on x86_64-unknown-linux-gnu in progress.
>
> Ok?
>
> Thanks,
> Richard.
>
> 2015-03-09 Richard Biener <rguenther@suse.de>
>
> PR middle-end/44563
> * cgraph.h (struct cgraph_edge_hasher): Add hash overload
> for compare_type.
> * cgraph.c (cgraph_edge_hasher::hash): Inline htab_hash_pointer.
> (cgraph_update_edge_in_call_site_hash): Use cgraph_edge_hasher::hash.
> (cgraph_add_edge_to_call_site_hash): Likewise.
> (cgraph_node::get_edge): Likewise.
> (cgraph_edge::set_call_stmt): Likewise.
> (cgraph_edge::remove_caller): Likewise.
Seems reosnable to me and patch is OK. Since hash-map is now GGC safe, won't
it be faster to use it instead? The hash is really mapping stmts to edges, so
hash-map seems most fitting datastructure in our grand new C++ world.
Honza
next prev parent reply other threads:[~2015-03-10 5:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 15:12 Richard Biener
2015-03-09 15:48 ` Steven Bosscher
2015-03-10 5:12 ` Jan Hubicka [this message]
2015-03-10 8:27 ` Richard Biener
2015-04-28 15:19 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310051250.GA59707@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).