From: Ilya Enkovich <enkovich.gnu@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, PR target/65103, 3/3] Change rtx cost for i386 address constants
Date: Tue, 10 Mar 2015 16:14:00 -0000 [thread overview]
Message-ID: <20150310161437.GG27860@msticlxl57.ims.intel.com> (raw)
In-Reply-To: <20150310151140.GD27860@msticlxl57.ims.intel.com>
On 10 Mar 18:11, Ilya Enkovich wrote:
> Hi,
>
> This patch changes rtx cost for address constants to 0 similar to what we have in address cost hook beacuse we expect them to be propagated into address expression anyway. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk or stage 1?
>
> Thanks,
> Ilya
Updated ChangeLog and test.
Thanks,
Ilya
--
gcc/
2015-03-10 Ilya Enkovich <ilya.enkovich@intel.com>
PR target/65103
* config/i386/i386.c (ix86_rtx_costs): We want to propagate
link time constants into adress expressions and therefore set
their cost to 0.
gcc/testsuite/
2015-03-10 Ilya Enkovich <ilya.enkovich@intel.com>
PR target/65103
* gcc.target/i386/pr65103-3.c: New.
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index b3971b8..341a157 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -42039,7 +42039,8 @@ ix86_rtx_costs (rtx x, int code_i, int outer_code_i, int opno, int *total,
&& !(TARGET_64BIT
&& (GET_CODE (x) == LABEL_REF
|| (GET_CODE (x) == SYMBOL_REF
- && SYMBOL_REF_LOCAL_P (x)))))
+ && SYMBOL_REF_LOCAL_P (x))))
+ && (TARGET_64BIT || GET_CODE (x) != CONST))
*total = 1;
else
*total = 0;
diff --git a/gcc/testsuite/gcc.target/i386/pr65103-3.c b/gcc/testsuite/gcc.target/i386/pr65103-3.c
new file mode 100644
index 0000000..eddf20b
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr65103-3.c
@@ -0,0 +1,19 @@
+/* { dg-do compile { target ia32 } } */
+/* { dg-require-effective-target pie } */
+/* { dg-options "-O2 -fPIE" } */
+/* { dg-final { scan-assembler-not "GOTOFF," } } */
+
+static int *data[100];
+
+void test (long a, long b)
+{
+ do
+ {
+ if( a < b )
+ {
+ data[a] = data[b];
+ a++;
+ }
+ }
+ while (a <= b);
+}
next prev parent reply other threads:[~2015-03-10 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 15:11 Ilya Enkovich
2015-03-10 16:14 ` Ilya Enkovich [this message]
2015-05-12 14:43 ` Ilya Enkovich
2015-05-12 15:47 Uros Bizjak
2015-05-13 8:39 ` Ilya Enkovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310161437.GG27860@msticlxl57.ims.intel.com \
--to=enkovich.gnu@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).