[patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[Jonathan Wakely]

It has just occurred to me we might want to make this change for GCC5:


diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
index 1727140..0b8c0f0 100644
--- a/libstdc++-v3/acinclude.m4
+++ b/libstdc++-v3/acinclude.m4
@@ -1219,11 +1219,11 @@ AC_DEFUN([GLIBCXX_ENABLE_LIBSTDCXX_TIME], [
           ac_has_clock_realtime=yes
         fi
         ac_has_nanosleep=yes
         ac_has_sched_yield=yes
         ;;
-      freebsd*|netbsd*)
+      freebsd*|netbsd*|dragonfly*)
         ac_has_clock_monotonic=yes
         ac_has_clock_realtime=yes
         ac_has_nanosleep=yes
         ac_has_sched_yield=yes
         ;;


We could make this change post-GCC5 but as the dragonfly target is new
for GCC5 it would be a shame to release it with a sub-optimal
resolution for clocks and thread sleeping.

John, assuming I'm right that dragonfly supports all these features,
could you test this change?  (You'll need the same change on line
19555 of the libstdc++-v3/configure script.)

Re: [patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[Jeff Law]

On 03/10/15 13:23, Jonathan Wakely wrote:
> It has just occurred to me we might want to make this change for GCC5:
>
>
> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
> index 1727140..0b8c0f0 100644
> --- a/libstdc++-v3/acinclude.m4
> +++ b/libstdc++-v3/acinclude.m4
> @@ -1219,11 +1219,11 @@ AC_DEFUN([GLIBCXX_ENABLE_LIBSTDCXX_TIME], [
>            ac_has_clock_realtime=yes
>          fi
>          ac_has_nanosleep=yes
>          ac_has_sched_yield=yes
>          ;;
> -      freebsd*|netbsd*)
> +      freebsd*|netbsd*|dragonfly*)
>          ac_has_clock_monotonic=yes
>          ac_has_clock_realtime=yes
>          ac_has_nanosleep=yes
>          ac_has_sched_yield=yes
>          ;;
>
>
> We could make this change post-GCC5 but as the dragonfly target is new
> for GCC5 it would be a shame to release it with a sub-optimal
> resolution for clocks and thread sleeping.
>
> John, assuming I'm right that dragonfly supports all these features,
> could you test this change?  (You'll need the same change on line
> 19555 of the libstdc++-v3/configure script.)
Given the narrow scope for potential breakage, it seems fine to me.

jeff

Re: [patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[John Marino]

On 3/10/2015 20:23, Jonathan Wakely wrote:
> It has just occurred to me we might want to make this change for GCC5:
> 
> 
> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
> index 1727140..0b8c0f0 100644
> --- a/libstdc++-v3/acinclude.m4
> +++ b/libstdc++-v3/acinclude.m4
> @@ -1219,11 +1219,11 @@ AC_DEFUN([GLIBCXX_ENABLE_LIBSTDCXX_TIME], [
>           ac_has_clock_realtime=yes
>         fi
>         ac_has_nanosleep=yes
>         ac_has_sched_yield=yes
>         ;;
> -      freebsd*|netbsd*)
> +      freebsd*|netbsd*|dragonfly*)
>         ac_has_clock_monotonic=yes
>         ac_has_clock_realtime=yes
>         ac_has_nanosleep=yes
>         ac_has_sched_yield=yes
>         ;;
> 
> 
> We could make this change post-GCC5 but as the dragonfly target is new
> for GCC5 it would be a shame to release it with a sub-optimal
> resolution for clocks and thread sleeping.
> 
> John, assuming I'm right that dragonfly supports all these features,
> could you test this change?  (You'll need the same change on line
> 19555 of the libstdc++-v3/configure script.)
> 

Sure, I can test it.  How can I tell if the result is successful?
Successful build versus failed build?

Thanks,
John

Re: [patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[Jonathan Wakely]

On 10/03/15 20:55 +0100, John Marino wrote:
>On 3/10/2015 20:23, Jonathan Wakely wrote:
>> John, assuming I'm right that dragonfly supports all these features,
>> could you test this change?  (You'll need the same change on line
>> 19555 of the libstdc++-v3/configure script.)
>>
>
>Sure, I can test it.  How can I tell if the result is successful?
>Successful build versus failed build?

Yes, that should be enough. If any of sched_yield(), nanosleep(),
clock_gettime() etc. is missing you'll get a build failure.

I'll do a full testsuite run (bootstrap and 'make check') on dragonfly
before committing, but I'll need some time to resurrect the dragonfly
VM I was using previously.

Re: [patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[John Marino]

On 3/10/2015 21:18, Jonathan Wakely wrote:
> On 10/03/15 20:55 +0100, John Marino wrote:
>> On 3/10/2015 20:23, Jonathan Wakely wrote:
>>> John, assuming I'm right that dragonfly supports all these features,
>>> could you test this change?  (You'll need the same change on line
>>> 19555 of the libstdc++-v3/configure script.)
>>>
>>
>> Sure, I can test it.  How can I tell if the result is successful?
>> Successful build versus failed build?
> 
> Yes, that should be enough. If any of sched_yield(), nanosleep(),
> clock_gettime() etc. is missing you'll get a build failure.
> 
> I'll do a full testsuite run (bootstrap and 'make check') on dragonfly
> before committing, but I'll need some time to resurrect the dragonfly
> VM I was using previously.

Hi Jonathan,
gcc 5 built fine on DragonFly with your patch:
http://muscles.dragonflybsd.org/bulk/bleeding-edge-potential/20150310_142205/logs/gcc5-5.0.s20150308.log

Regards,
John

Re: [patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[John Marino]

On 3/10/2015 23:04, John Marino wrote:
> On 3/10/2015 21:18, Jonathan Wakely wrote:
>> On 10/03/15 20:55 +0100, John Marino wrote:
>>> On 3/10/2015 20:23, Jonathan Wakely wrote:
>>>> John, assuming I'm right that dragonfly supports all these features,
>>>> could you test this change?  (You'll need the same change on line
>>>> 19555 of the libstdc++-v3/configure script.)
>>>>
>>>
>>> Sure, I can test it.  How can I tell if the result is successful?
>>> Successful build versus failed build?
>>
>> Yes, that should be enough. If any of sched_yield(), nanosleep(),
>> clock_gettime() etc. is missing you'll get a build failure.
>>
>> I'll do a full testsuite run (bootstrap and 'make check') on dragonfly
>> before committing, but I'll need some time to resurrect the dragonfly
>> VM I was using previously.
> 
> Hi Jonathan,
> gcc 5 built fine on DragonFly with your patch:
> http://muscles.dragonflybsd.org/bulk/bleeding-edge-potential/20150310_142205/logs/gcc5-5.0.s20150308.log
> 

Hi Jonathan,
Today I build gcc5 and looked at the config.h contained in
libstdc++-v3's build directory and none of those variables are enabled.

The code that is patched doesn't seem to do anything.  I grepped the
entire build directory for "libstdcxx_time" and got no results.

I don't have "--enable-libstdcxx-time" set as a configure argument.  So
I am thinking somehow this configuration check got skipped completely.

John

Re: [patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[Jonathan Wakely]

On 13 March 2015 at 08:50, John Marino wrote:
> Hi Jonathan,
> Today I build gcc5 and looked at the config.h contained in
> libstdc++-v3's build directory and none of those variables are enabled.
>
> The code that is patched doesn't seem to do anything.  I grepped the
> entire build directory for "libstdcxx_time" and got no results.
>
> I don't have "--enable-libstdcxx-time" set as a configure argument.  So
> I am thinking somehow this configuration check got skipped completely.

Hi John,

The variables cause additional checks to be run in configure, which
then result in these macros in c++config.h


/* Defined if clock_gettime has monotonic clock support. */
#define _GLIBCXX_USE_CLOCK_MONOTONIC 1

/* Defined if clock_gettime has realtime clock support. */
#define _GLIBCXX_USE_CLOCK_REALTIME 1

and

/* Defined if nanosleep is available. */
#define _GLIBCXX_USE_NANOSLEEP 1

and

/* Defined if sched_yield is available. */
#define _GLIBCXX_USE_SCHED_YIELD 1

I see these defined in
include/x86_64-unknown-dragonfly3.6/bits/c++config.h and I also see
previously UNSUPPORTED tests now PASS, so I think it's working.

Re: [patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[John Marino]

On 3/13/2015 11:23, Jonathan Wakely wrote:
> On 13 March 2015 at 08:50, John Marino wrote:
>> Hi Jonathan,
>> Today I build gcc5 and looked at the config.h contained in
>> libstdc++-v3's build directory and none of those variables are enabled.
>>
>> The code that is patched doesn't seem to do anything.  I grepped the
>> entire build directory for "libstdcxx_time" and got no results.
>>
>> I don't have "--enable-libstdcxx-time" set as a configure argument.  So
>> I am thinking somehow this configuration check got skipped completely.
> 
> Hi John,
> 
> The variables cause additional checks to be run in configure, which
> then result in these macros in c++config.h

Okay. I guess I was just looking at the wrong config file then.
Thanks for sorting out that confusion!
John

Re: [patch] Use --enable-libstdcxx-time=yes on DragonFly BSD

[Jonathan Wakely]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On 10/03/15 20:18 +0000, Jonathan Wakely wrote:
>On 10/03/15 20:55 +0100, John Marino wrote:
>>On 3/10/2015 20:23, Jonathan Wakely wrote:
>>>John, assuming I'm right that dragonfly supports all these features,
>>>could you test this change?  (You'll need the same change on line
>>>19555 of the libstdc++-v3/configure script.)
>>>
>>
>>Sure, I can test it.  How can I tell if the result is successful?
>>Successful build versus failed build?
>
>Yes, that should be enough. If any of sched_yield(), nanosleep(),
>clock_gettime() etc. is missing you'll get a build failure.
>
>I'll do a full testsuite run (bootstrap and 'make check') on dragonfly
>before committing, but I'll need some time to resurrect the dragonfly
>VM I was using previously.

I've done that testing and committed it to trunk now.


[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 1147 bytes --]

commit 16ed217e6b129861980c7f7c92964203708684e5
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Mar 12 13:20:06 2015 +0000

    	* acinclude.m4: Make --enable-libstdcxx-time=auto work for dragonfly.
    	* configure: Regenerate.

diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
index 1727140..0b8c0f0 100644
--- a/libstdc++-v3/acinclude.m4
+++ b/libstdc++-v3/acinclude.m4
@@ -1221,7 +1221,7 @@ AC_DEFUN([GLIBCXX_ENABLE_LIBSTDCXX_TIME], [
         ac_has_nanosleep=yes
         ac_has_sched_yield=yes
         ;;
-      freebsd*|netbsd*)
+      freebsd*|netbsd*|dragonfly*)
         ac_has_clock_monotonic=yes
         ac_has_clock_realtime=yes
         ac_has_nanosleep=yes
diff --git a/libstdc++-v3/configure b/libstdc++-v3/configure
index acd8c60..bcdb931 100755
--- a/libstdc++-v3/configure
+++ b/libstdc++-v3/configure
@@ -19551,7 +19551,7 @@ $as_echo "$glibcxx_glibc217" >&6; }
         ac_has_nanosleep=yes
         ac_has_sched_yield=yes
         ;;
-      freebsd*|netbsd*)
+      freebsd*|netbsd*|dragonfly*)
         ac_has_clock_monotonic=yes
         ac_has_clock_realtime=yes
         ac_has_nanosleep=yes