From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-393511-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 27767 invoked by alias); 13 Mar 2015 14:12:47 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 27753 invoked by uid 89); 13 Mar 2015 14:12:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: gate.crashing.org
Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 13 Mar 2015 14:12:45 +0000
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])	by gate.crashing.org (8.14.1/8.13.8) with ESMTP id t2DECUNf030842;	Fri, 13 Mar 2015 09:12:30 -0500
Received: (from segher@localhost)	by gate.crashing.org (8.14.1/8.14.1/Submit) id t2DECTOt030838;	Fri, 13 Mar 2015 09:12:29 -0500
Date: Fri, 13 Mar 2015 14:12:00 -0000
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: "'Honggyu Kim'" <hong.gyu.kim@lge.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][ARM] New testcase to check parameter passing bug
Message-ID: <20150313141229.GC7174@gate.crashing.org>
References: <1426212518-14867-1-git-send-email-hong.gyu.kim@lge.com> <000801d05d85$dbcb9450$9362bcf0$@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000801d05d85$dbcb9450$9362bcf0$@arm.com>
User-Agent: Mutt/1.4.2.3i
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg00751.txt.bz2

On Fri, Mar 13, 2015 at 12:04:28PM -0000, Kyrill Tkachov wrote:
> > diff --git a/gcc/testsuite/gcc.target/arm/pr65358.c
> > b/gcc/testsuite/gcc.target/arm/pr65358.c
> > new file mode 100644
> > index 0000000..d663dcf
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/arm/pr65358.c
> > @@ -0,0 +1,34 @@
> > +/* PR target/65358 */
> > +/* { dg-do compile { target arm*-*-* } } */
> 
> No need for the target selector. The fact that it's in gcc.target/arm
> already
> means it will only be run for the arm targets.
> Also, the bug is exposed at runtime, so this should be a dg-do run test.

Why make this testcase arm-specific at all?  I don't see anything that
wouldn't work on other targets?


Segher