From: Jakub Jelinek <jakub@redhat.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
Alan Modra <amodra@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: Fix for PRs 36043, 58744 and 65408
Date: Sat, 14 Mar 2015 17:56:00 -0000 [thread overview]
Message-ID: <20150314175601.GM1746@tucnak.redhat.com> (raw)
In-Reply-To: <277E04CB-8E5D-4F1D-BECA-8A97BDD43DF7@comcast.net>
On Sat, Mar 14, 2015 at 10:51:28AM -0700, Mike Stump wrote:
> On Mar 14, 2015, at 6:58 AM, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
> > On March 14, 2015 2:02:38 PM GMT+01:00, Alan Modra <amodra@gmail.com> wrote:
> >
> >> I'll also throw together a testcase or three. For execute tests I'm
> >> thinking of using sbrk to locate an odd sized struct such that access
> >> past the end segfaults, rather than mmap/munmap as was done in the
> >> pr36043 testcase. Does that sound reasonable?
> >
> > Well since sbrk was marked LEGACY in SUSv2 and was removed in SUSv3 (and still is in 1003.1-2008) I'm not sure it is wise to use it in new code.. Using it will bite testing on legacy-free setups, fwiw.
>
> newlib doesn’t have mmap. Indeed, some machines will never have mmap. newlib has sbrk.
Still, I think it is preferrable to test with mmap...
Jakub
next prev parent reply other threads:[~2015-03-14 17:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 13:02 Alan Modra
2015-03-14 13:14 ` H.J. Lu
2015-03-14 13:55 ` Alan Modra
2015-03-14 13:58 ` Bernhard Reutner-Fischer
2015-03-14 17:52 ` Mike Stump
2015-03-14 17:56 ` Jakub Jelinek [this message]
2015-03-14 18:28 ` Mike Stump
2015-03-15 3:00 ` Alan Modra
2015-03-17 19:28 ` Jeff Law
2015-03-18 4:22 ` Alan Modra
2015-03-18 11:12 ` Richard Biener
2015-04-13 4:50 ` Alan Modra
2015-04-13 7:47 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150314175601.GM1746@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).