From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61459 invoked by alias); 24 Mar 2015 11:51:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 61408 invoked by uid 89); 24 Mar 2015 11:51:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 24 Mar 2015 11:51:18 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id t2OBp0kv031804; Tue, 24 Mar 2015 06:51:01 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id t2OBoviU031803; Tue, 24 Mar 2015 06:50:57 -0500 Date: Tue, 24 Mar 2015 11:51:00 -0000 From: Segher Boessenkool To: Martin Sebor Cc: Iain Sandoe , Gcc Patch List , anton@samba.org Subject: Re: [PATCH] pr 63354 - gcc -pg -mprofile-kernel creates unused stack frames on leaf functions on ppc64le Message-ID: <20150324115055.GA13016@gate.crashing.org> References: <55035CB1.4020801@redhat.com> <20150314143434.GC3690@gate.crashing.org> <5506184F.8090006@redhat.com> <210B149C-A8AB-4A0C-98AA-90D72741A7AF@codesourcery.com> <5510D0F3.4060606@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5510D0F3.4060606@redhat.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01243.txt.bz2 On Mon, Mar 23, 2015 at 08:50:27PM -0600, Martin Sebor wrote: > >>>> PR target/63354 > >>>> * gcc/config/rs6000/linux64.h (ARGET_KEEP_LEAF_WHEN_PROFILED): > >>>> Define. > >>> ^ typo > > It's fixed in version 2 of the patch posted here: > https://gcc.gnu.org/ml/gcc-patches/2015-03/msg00793.html Iain means the macro should be defined in rs6000.h, not linux64.h. > >This ^ will cause a bootstrap fail for every rs6000 target that doesn't > >include linux64.h. > >(because rs6000_keep_leaf_when_profiled will be "defined but unused"). > > > >Since ISTM you intend this to apply to all rs6000 sub-targets, you might > >as well move it to rs6000.h? Segher