From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10274 invoked by alias); 25 Mar 2015 16:23:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10212 invoked by uid 89); 25 Mar 2015 16:23:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 25 Mar 2015 16:23:39 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id DE85D8E6EE; Wed, 25 Mar 2015 16:23:37 +0000 (UTC) Received: from localhost (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2PGNapr027651; Wed, 25 Mar 2015 12:23:37 -0400 Date: Wed, 25 Mar 2015 16:23:00 -0000 From: Jonathan Wakely To: Alan Lawrence Cc: "gcc-patches@gcc.gnu.org" , "libstdc++@gcc.gnu.org" Subject: Re: [Obvious] Fix libstdc++/33394 testcase when cross-testing linux Message-ID: <20150325162336.GG9755@redhat.com> References: <20150324143900.GE9755@redhat.com> <5512D8F8.2080200@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <5512D8F8.2080200@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-03/txt/msg01309.txt.bz2 On 25/03/15 15:49 +0000, Alan Lawrence wrote: >When cross-testing, the -DITERATIONS=1000 flag replaced the -pthread >required for linux targets, so the test failed to build. I've pushed >the following test fix as r221666: Ah yes, of course it does! Thanks for the fix. >Index: libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc >=================================================================== >--- libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc >(revision 221665) >+++ libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc >(working copy) >@@ -18,7 +18,7 @@ > // { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* >*-*-linux* *-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* } } > // { dg-options "-pthread" { target *-*-freebsd* *-*-dragonfly* >*-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* } } > >-// { dg-options "-DITERATIONS=1000" { target simulator } } >+// { dg-additional-options "-DITERATIONS=1000" { target simulator } } > #ifndef ITERATIONS > #define ITERATIONS 50000 > #endif > >Jonathan Wakely wrote: >>Adding a testcase so the bug can be closed. >> >>I believe the segfault was fixed for 3.4.0 by >>https://gcc.gnu.org/r67912 >> >>Tested x86_64-linux, committed to trunk. >