From: Jan Hubicka <hubicka@ucw.cz>
To: gcc-patches@gcc.gnu.org, ilya.enkovich@intel.com
Subject: Fix ice on comdat groups with -check-pointer-bounds
Date: Fri, 27 Mar 2015 15:23:00 -0000 [thread overview]
Message-ID: <20150327152309.GD63825@kam.mff.cuni.cz> (raw)
Hi,
this patch fixes bug in symtab_node::verify_symtab_nodes pointed out by Ilya.
The loop checking that there all comdats are linked by same_comdat_group was
completely bogus. In addition it checked also external symbols that are
currently not kept in groups. This bug was in mainline for months but
apparently bounds checking is first code producing interesting comdat groups to
trigger it.
Ilya, can you please mind comitting the testcase? I am not quite sure where
bounds checking should go offhand.
Also concerning linking the comdat groups, currently all non-DECL_EXTERNAL symbols
are linked and all !DECL_EXTERNAL symbols are non-linked. Bounds checking should
follow this scheme. It may be cleaner to keep links for DECL_EXTERNAL, but lets
deffer that for next stage1.
Bootstrapped/regtested x86_64-linux. Committed.
Honza
Index: ChangeLog
===================================================================
--- ChangeLog (revision 221735)
+++ ChangeLog (working copy)
@@ -1,5 +1,11 @@
2015-03-27 Jan Hubicka <hubicka@ucw.cz>
+ PR target/65531
+ * symtab.c (symtab_node::verify_symtab_nodes): Fix verification of
+ comdat groups.
+
+2015-03-27 Jan Hubicka <hubicka@ucw.cz>
+
PR ipa/65600
* cgraph.c (cgraph_update_edges_for_call_stmt_node): Fix the case
of optimized out indirect call.
Index: symtab.c
===================================================================
--- symtab.c (revision 221734)
+++ symtab.c (working copy)
@@ -1130,15 +1130,20 @@ symtab_node::verify_symtab_nodes (void)
&existed);
if (!existed)
*entry = node;
- else
- for (s = (*entry)->same_comdat_group; s != NULL && s != node; s = s->same_comdat_group)
+ else if (!DECL_EXTERNAL (node->decl))
+ {
+ for (s = (*entry)->same_comdat_group; s != NULL && s != node;
+ s = s->same_comdat_group)
+ ;
if (!s || s == *entry)
{
- error ("Two symbols with same comdat_group are not linked by the same_comdat_group list.");
+ error ("Two symbols with same comdat_group are not linked by "
+ "the same_comdat_group list.");
(*entry)->debug ();
node->debug ();
internal_error ("symtab_node::verify failed");
}
+ }
}
}
}
next reply other threads:[~2015-03-27 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 15:23 Jan Hubicka [this message]
2015-03-30 9:59 ` Ilya Enkovich
2015-03-30 11:05 ` Ilya Enkovich
2015-03-30 11:31 ` Ilya Enkovich
2015-03-30 17:20 ` Jan Hubicka
2015-03-31 11:43 ` Ilya Enkovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327152309.GD63825@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=ilya.enkovich@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).