Re: [PATCH][ada][PR65490] Fix bzero warning in child_setup_tty

[Arnaud Charlet <charlet@adacore.com>]

> OK for stage 4/stage1?
> 
> Thanks,
> - Tom

> Fix bzero warning in child_setup_tty
> 
> 2015-03-30  Tom de Vries  <tom@codesourcery.com>
> 
> 	PR ada/65490
> 	* terminals.c (child_setup_tty): Fix warning 'argument to sizeof in
> 	bzero call is the same expression as the destination'.
> ---
>  gcc/ada/terminals.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gcc/ada/terminals.c b/gcc/ada/terminals.c
> index a46e610..eaaf1c2 100644
> --- a/gcc/ada/terminals.c
> +++ b/gcc/ada/terminals.c
> @@ -1262,8 +1262,8 @@ child_setup_tty (int fd)
>    struct termios s;
>    int    status;
>  
> -  /* ensure that s is filled with 0 */
> -  bzero (&s, sizeof (&s));
> +  /* Ensure that s is filled with 0.  */

Please keep the comment as is, we do not put dots on single partial sentences
(otherwise you would have to change these everywhere, and you and I do not
really want that).

> +  bzero (&s, sizeof (s));

the above single line change is OK for stage 4, thanks.

Arno