From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44747 invoked by alias); 31 Mar 2015 07:58:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 44725 invoked by uid 89); 31 Mar 2015 07:58:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 Mar 2015 07:58:12 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 830CC2D45F2A; Tue, 31 Mar 2015 09:58:07 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JIS66cP6RZ-O; Tue, 31 Mar 2015 09:58:07 +0200 (CEST) Received: from chelles.act-europe.fr (chelles.act-europe.fr [10.10.0.160]) by smtp.eu.adacore.com (Postfix) with ESMTP id 44D982D45F21; Tue, 31 Mar 2015 09:58:06 +0200 (CEST) Received: by chelles.act-europe.fr (Postfix, from userid 525) id DEDCB1EA5DEE; Tue, 31 Mar 2015 09:58:06 +0200 (CEST) Date: Tue, 31 Mar 2015 07:58:00 -0000 From: Arnaud Charlet To: Tom de Vries Cc: GCC Patches Subject: Re: [PATCH][ada][PR65490] Fix bzero warning in child_setup_tty Message-ID: <20150331075806.GA11491@adacore.com> References: <551956B6.4030805@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551956B6.4030805@mentor.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-03/txt/msg01618.txt.bz2 > OK for stage 4/stage1? > > Thanks, > - Tom > Fix bzero warning in child_setup_tty > > 2015-03-30 Tom de Vries > > PR ada/65490 > * terminals.c (child_setup_tty): Fix warning 'argument to sizeof in > bzero call is the same expression as the destination'. > --- > gcc/ada/terminals.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/ada/terminals.c b/gcc/ada/terminals.c > index a46e610..eaaf1c2 100644 > --- a/gcc/ada/terminals.c > +++ b/gcc/ada/terminals.c > @@ -1262,8 +1262,8 @@ child_setup_tty (int fd) > struct termios s; > int status; > > - /* ensure that s is filled with 0 */ > - bzero (&s, sizeof (&s)); > + /* Ensure that s is filled with 0. */ Please keep the comment as is, we do not put dots on single partial sentences (otherwise you would have to change these everywhere, and you and I do not really want that). > + bzero (&s, sizeof (s)); the above single line change is OK for stage 4, thanks. Arno