From: Arnaud Charlet <charlet@adacore.com>
To: Tom de Vries <Tom_deVries@mentor.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][ada][PR65490] Fix bzero warning in child_setup_tty
Date: Tue, 31 Mar 2015 07:59:00 -0000 [thread overview]
Message-ID: <20150331075951.GB11491@adacore.com> (raw)
In-Reply-To: <20150331075806.GA11491@adacore.com>
> > - /* ensure that s is filled with 0 */
> > - bzero (&s, sizeof (&s));
> > + /* Ensure that s is filled with 0. */
>
> Please keep the comment as is, we do not put dots on single partial sentences
> (otherwise you would have to change these everywhere, and you and I do not
> really want that).
>
> > + bzero (&s, sizeof (s));
>
> the above single line change is OK for stage 4, thanks.
Plus the copyright update (to 2015).
--
--- terminals.c (revision 313797)
+++ terminals.c (working copy)
@@ -6,7 +6,7 @@
* *
* C Implementation File *
* *
- * Copyright (C) 2008-2014, AdaCore *
+ * Copyright (C) 2008-2015, AdaCore *
* *
* GNAT is free software; you can redistribute it and/or modify it under *
* terms of the GNU General Public License as published by the Free Soft- *
@@ -1263,7 +1263,7 @@
int status;
/* ensure that s is filled with 0 */
- bzero (&s, sizeof (&s));
+ bzero (&s, sizeof (s));
/* Get the current terminal settings */
status = tcgetattr (fd, &s);
prev parent reply other threads:[~2015-03-31 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 14:00 Tom de Vries
2015-03-31 7:58 ` Arnaud Charlet
2015-03-31 7:59 ` Arnaud Charlet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331075951.GB11491@adacore.com \
--to=charlet@adacore.com \
--cc=Tom_deVries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).