From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48260 invoked by alias); 31 Mar 2015 07:59:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48249 invoked by uid 89); 31 Mar 2015 07:59:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 Mar 2015 07:59:55 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 13CF92D45F2D; Tue, 31 Mar 2015 09:59:52 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DXDW6M7lACL0; Tue, 31 Mar 2015 09:59:52 +0200 (CEST) Received: from chelles.act-europe.fr (chelles.act-europe.fr [10.10.0.160]) by smtp.eu.adacore.com (Postfix) with ESMTP id 0255B2D45F21; Tue, 31 Mar 2015 09:59:52 +0200 (CEST) Received: by chelles.act-europe.fr (Postfix, from userid 525) id 004121EA5DEE; Tue, 31 Mar 2015 09:59:51 +0200 (CEST) Date: Tue, 31 Mar 2015 07:59:00 -0000 From: Arnaud Charlet To: Tom de Vries Cc: GCC Patches Subject: Re: [PATCH][ada][PR65490] Fix bzero warning in child_setup_tty Message-ID: <20150331075951.GB11491@adacore.com> References: <551956B6.4030805@mentor.com> <20150331075806.GA11491@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150331075806.GA11491@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-03/txt/msg01619.txt.bz2 > > - /* ensure that s is filled with 0 */ > > - bzero (&s, sizeof (&s)); > > + /* Ensure that s is filled with 0. */ > > Please keep the comment as is, we do not put dots on single partial sentences > (otherwise you would have to change these everywhere, and you and I do not > really want that). > > > + bzero (&s, sizeof (s)); > > the above single line change is OK for stage 4, thanks. Plus the copyright update (to 2015). -- --- terminals.c (revision 313797) +++ terminals.c (working copy) @@ -6,7 +6,7 @@ * * * C Implementation File * * * - * Copyright (C) 2008-2014, AdaCore * + * Copyright (C) 2008-2015, AdaCore * * * * GNAT is free software; you can redistribute it and/or modify it under * * terms of the GNU General Public License as published by the Free Soft- * @@ -1263,7 +1263,7 @@ int status; /* ensure that s is filled with 0 */ - bzero (&s, sizeof (&s)); + bzero (&s, sizeof (s)); /* Get the current terminal settings */ status = tcgetattr (fd, &s);