From: Ilya Tocar <tocarip.intel@gmail.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, i386] PR63211 broken type-punning in avx* tests.
Date: Fri, 03 Apr 2015 14:52:00 -0000 [thread overview]
Message-ID: <20150403145207.GC23405@msticlxl7.ims.intel.com> (raw)
In-Reply-To: <CAFULd4Zeq2UKXqCPO4r6mNci5CFzWarN=YaXWULUFf2PPZew9g@mail.gmail.com>
On 03 Apr 13:39, Uros Bizjak wrote:
> On Fri, Apr 3, 2015 at 1:02 PM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>
> > I've looked into avx* tests and many of them (even those that don't fail
> > in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63211) use invalid type
> > punning. Properly fixing them looks like a lot of work, so I propose
> > just adding -fno-strict-aliasing to them.
> > This patch was obtained by running
> > sed -i "s/-O2/-O2 -fno-strict-aliasing/g" ../gcc/testsuite/gcc.target/i386/avx*-2.c
> >
> > Ok for stage1?
>
> I don't like this approach. If the testcase is broken, then it should
> be fixed, not worked around.
>
IMHO those tests don't need to be alias conformant.
There are plenty of tests for aliasing rules,
and avx tests verify intrinsics implementaion. There are plenty of real
programs braking alias rules, so why can't we have non-conformant tests?
next prev parent reply other threads:[~2015-04-03 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 11:02 Ilya Tocar
2015-04-03 11:39 ` Uros Bizjak
2015-04-03 14:52 ` Ilya Tocar [this message]
2015-04-04 8:08 ` Uros Bizjak
2015-04-06 15:44 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403145207.GC23405@msticlxl7.ims.intel.com \
--to=tocarip.intel@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kirill.yukhin@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).