From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Be less conservative in process_{output,input}_constraints (PR target/65689)
Date: Wed, 08 Apr 2015 22:12:00 -0000 [thread overview]
Message-ID: <20150408221207.GB26923@gate.crashing.org> (raw)
In-Reply-To: <20150408210059.GZ19273@tucnak.redhat.com>
On Wed, Apr 08, 2015 at 11:00:59PM +0200, Jakub Jelinek wrote:
> + case MATCH_CODE:
> + if (*XSTR (exp, 1) == '\0')
> + {
> + const char *code, *codes = XSTR (exp, 0);
> + int ret = 0;
> + while ((code = scan_comma_elt (&codes)) != 0)
> + if (strncmp (code, "reg", 3) == 0
> + && (code[3] == ',' || code[3] == '\0' || code[3] == ' '))
This doesn't allow other whitespace. Maybe it's cleaner written as e.g.
&& codes - code == 3
?
Segher
next prev parent reply other threads:[~2015-04-08 22:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 21:01 Jakub Jelinek
2015-04-08 22:12 ` Segher Boessenkool [this message]
2015-04-08 22:16 ` Segher Boessenkool
2015-04-08 22:20 ` Jakub Jelinek
2015-04-09 6:58 ` Jakub Jelinek
2015-04-09 9:03 ` Jakub Jelinek
2015-04-26 11:11 ` Richard Sandiford
2016-01-12 12:30 ` James Greenhalgh
2016-01-12 12:37 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408221207.GB26923@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).