From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117386 invoked by alias); 9 Apr 2015 20:09:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117375 invoked by uid 89); 9 Apr 2015 20:09:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Apr 2015 20:09:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t39K9XGG017763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 9 Apr 2015 16:09:33 -0400 Received: from tucnak.zalov.cz (ovpn-116-24.ams2.redhat.com [10.36.116.24]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t39K9VOH005705 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 9 Apr 2015 16:09:32 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t39K9Uhg015823; Thu, 9 Apr 2015 22:09:30 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t39K9ThL015822; Thu, 9 Apr 2015 22:09:29 +0200 Date: Thu, 09 Apr 2015 20:09:00 -0000 From: Jakub Jelinek To: Bernhard Reutner-Fischer Cc: GCC Patches , Douglas Rupp , Tristan Gingold Subject: Re: [PATCH] PR target/55143: undefined reference to `c_default_pointer_mode' Message-ID: <20150409200929.GP19273@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1428607654-16888-1-git-send-email-rep.dot.nop@gmail.com> <20150409194135.GO19273@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00414.txt.bz2 On Thu, Apr 09, 2015 at 09:57:29PM +0200, Bernhard Reutner-Fischer wrote: > On 9 April 2015 at 21:41, Jakub Jelinek wrote: > > On Thu, Apr 09, 2015 at 09:27:34PM +0200, Bernhard Reutner-Fischer wrote: > >> gcc/ChangeLog: > >> > >> 2015-04-08 Bernhard Reutner-Fischer > >> > >> PR target/55143 > >> * c/c-tree.h (c_default_pointer_mode): Move declaration ... > >> * c-family/c-common.h (c_default_pointer_mode): ... here. > >> * c/c-decl.c (c_default_pointer_mode): Move definition ... > >> * c-family/c-common.c (c_default_pointer_mode): ... here. > > > > The ChangeLog is certainly wrong, as both c and c-family have their own > > ChangeLog files, so you really can't write it using ... on both sides. > > So.. modulo leading tabs: > gcc/c/ChangeLog: > > 2015-04-09 Bernhard Reutner-Fischer > > PR target/55143 > * c-decl.c (c_default_pointer_mode): Remove definition. > * c-tree.h (c_default_pointer_mode): Remove declaration. > > gcc/c-family/ChangeLog: > > 2015-04-09 Bernhard Reutner-Fischer > > PR target/55143 > * c-common.c (c_default_pointer_mode): Add definition. > * c-common.h (c_default_pointer_mode): Add declaration. > > Ok for trunk? The c_default_pointer_mode is very ugly hack, but guess at least for now it is ok for trunk. Jakub