public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias.burnus@physik.fu-berlin.de>
To: Mikael Morin <mikael.morin@sfr.fr>
Cc: Evangelos Drikos <drikosev@otenet.gr>,
	fortran@gcc.gnu.org,	gcc-patches@gcc.gnu.org
Subject: Re: [Patch, fortran] PR59016, second version
Date: Fri, 10 Apr 2015 10:24:00 -0000	[thread overview]
Message-ID: <20150410102414.GA976@physik.fu-berlin.de> (raw)
In-Reply-To: <5526FAE2.2010000@sfr.fr>

Hello,

Mikael Morin wrote:
> I have finally taken over PR59016.
> The bug was a pointer to a freed (derived type) symbol retained in the
> generic one with the same name, because the symbols weren't versioned.
>
> Evangelos proposed a patch that was freeing the memory by hand.  The
> simpler one here, on the other hand, saves the symbol before any
> modification and lets the symbol undo code do its job.
> Thanks to Evangelos anyway for isolating the bug and proposing a fix.
>
> This patch has been tested on x86_64-unknown-linux-gnu.
> OK for trunk/4.9/4.8?

Thanks for the work on this, Evangelos and Mikael!
The patch looks good to me.

Cheers,

Tobias

      reply	other threads:[~2015-04-10 10:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-05 23:04 pr59016 Evangelos Drikos
2015-04-06 18:27 ` pr59016 Mikael Morin
2015-04-07 12:25   ` pr59016 Mikael Morin
2015-04-08 10:29     ` pr59016 Mikael Morin
2015-04-08 11:26       ` pr59016 Mikael Morin
2015-04-09 22:19         ` [Patch, fortran] PR59016, second version Mikael Morin
2015-04-10 10:24           ` Tobias Burnus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150410102414.GA976@physik.fu-berlin.de \
    --to=tobias.burnus@physik.fu-berlin.de \
    --cc=drikosev@otenet.gr \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mikael.morin@sfr.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).