From: Jonathan Wakely <jwakely@redhat.com>
To: Torvald Riegel <triegel@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [patch] Fix shared_timed_mutex::try_lock_until() et al
Date: Sat, 11 Apr 2015 11:48:00 -0000 [thread overview]
Message-ID: <20150411114850.GC9755@redhat.com> (raw)
In-Reply-To: <20150408191159.GQ9755@redhat.com>
On 08/04/15 20:11 +0100, Jonathan Wakely wrote:
>diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
>index 5871716..39d6866 100644
>--- a/libstdc++-v3/ChangeLog
>+++ b/libstdc++-v3/ChangeLog
>@@ -2,7 +2,8 @@
>
> * include/std/shared_mutex (shared_timed_mutex): Add comments to
> explain the logic.
>- (_M_n_readers): Rename to _S_n_readers.
>+ (_Mutex): Remove redundant type.
>+ (_M_n_readers): Rename to _S_max_readers.
> (_M_write_entered, _M_readers): New convenience functions.
> (lock, lock_shared, try_lock_shared, unlock_shared): Use convenience
> functions. Use predicates with condition variables. Simplify bitwise
>@@ -11,7 +12,8 @@
> and call try_lock_until or try_shared_lock_until respectively.
> (try_lock_until, try_shared_lock_until): Wait on the condition
> variables until the specified time passes.
>- (unlock, unlock_shared): Add Debug Mode assertions.
>+ (unlock): Add Debug Mode assertion.
>+ (unlock_shared): Add Debug Mode assertion.
> * testsuite/30_threads/shared_timed_mutex/try_lock/3.cc: New.
This has been committed to trunk and 4.9 (because on the 4.9 branch we
only had the non-pthread_rwlock_t version with broken timed lock
functions).
prev parent reply other threads:[~2015-04-11 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 14:28 Jonathan Wakely
2015-04-08 16:59 ` Torvald Riegel
2015-04-08 19:12 ` Jonathan Wakely
2015-04-08 19:38 ` Jonathan Wakely
2015-04-10 0:16 ` Torvald Riegel
2015-04-10 8:38 ` Jonathan Wakely
2015-04-10 9:56 ` Torvald Riegel
2015-04-10 10:21 ` Jonathan Wakely
2015-04-10 0:11 ` Torvald Riegel
2015-04-11 11:48 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150411114850.GC9755@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).