From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: jwakely@redhat.com
Cc: rth@redhat.com, libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
amacleod@redhat.com
Subject: patch fix issue 1 with "[libstdc++/65033] Give alignment info to libatomic"
Date: Mon, 13 Apr 2015 04:45:00 -0000 [thread overview]
Message-ID: <201504130445.t3D4jZ24003363@ignucius.se.axis.com> (raw)
In-Reply-To: <20150326132147.GL9755@redhat.com> (message from Jonathan Wakely on Thu, 26 Mar 2015 14:21:47 +0100)
> PR libstdc++/62259
> PR libstdc++/65147
> * include/std/atomic (atomic<T>): Increase alignment for types with
> the same size as one of the integral types.
> * testsuite/29_atomics/atomic/60695.cc: Adjust dg-error line number.
> * testsuite/29_atomics/atomic/62259.cc: New.
Ever since aligmnent was made sane-ish, 62259.cc has failed for
reasons obvious in the patch. Can I please commit this?
* testsuite/29_atomics/atomic/62259.cc: Assert atomic
alignment is larger-equal, not equal, to default alignment.
Index: libstdc++-v3/testsuite/29_atomics/atomic/62259.cc
===================================================================
--- libstdc++-v3/testsuite/29_atomics/atomic/62259.cc (revision 222036)
+++ libstdc++-v3/testsuite/29_atomics/atomic/62259.cc (working copy)
@@ -33,7 +33,7 @@ struct twoints {
int32_t b;
};
-static_assert( alignof(std::atomic<twoints>) == alignof(int64_t),
+static_assert( alignof(std::atomic<twoints>) >= alignof(int64_t),
"std::atomic not suitably aligned" );
// libstdc++/65147
@@ -44,7 +44,7 @@ struct power_of_two_obj {
std::atomic<power_of_two_obj> obj1;
-static_assert( alignof(obj1) == alignof(int64_t),
+static_assert( alignof(obj1) >= alignof(int64_t),
"std::atomic not suitably aligned" );
struct container_struct {
@@ -54,5 +54,5 @@ struct container_struct {
container_struct obj2;
-static_assert( alignof(obj2.ao) == alignof(int64_t),
+static_assert( alignof(obj2.ao) >= alignof(int64_t),
"std::atomic not suitably aligned" );
brgds, H-P
next prev parent reply other threads:[~2015-04-13 4:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 21:23 [libstdc++/65033] Give alignment info to libatomic Richard Henderson
2015-02-18 12:15 ` Jonathan Wakely
2015-03-25 16:22 ` Jonathan Wakely
2015-03-25 18:36 ` Richard Henderson
2015-03-25 18:49 ` Jonathan Wakely
2015-03-25 19:04 ` Richard Henderson
2015-03-26 13:21 ` Jonathan Wakely
2015-03-31 13:41 ` Jonathan Wakely
2015-03-31 14:54 ` Richard Henderson
2015-03-31 15:03 ` Jonathan Wakely
2015-03-31 15:13 ` Richard Henderson
2015-03-31 15:41 ` Jonathan Wakely
2015-04-06 22:59 ` Hans-Peter Nilsson
2015-04-13 4:45 ` Hans-Peter Nilsson [this message]
2015-04-13 11:59 ` patch fix issue 1 with "[libstdc++/65033] Give alignment info to libatomic" Jonathan Wakely
2015-04-13 5:59 ` Issue 2 " Hans-Peter Nilsson
2015-04-13 17:53 ` Joseph Myers
2015-03-25 18:39 ` [libstdc++/65033] Give alignment info to libatomic Richard Henderson
2015-04-03 3:04 ` Hans-Peter Nilsson
2015-03-26 11:54 ` Jonathan Wakely
2015-04-03 3:57 ` Hans-Peter Nilsson
2015-04-03 9:25 ` Hans-Peter Nilsson
2015-04-03 14:13 ` Jonathan Wakely
2015-04-03 19:13 ` Richard Henderson
2015-04-07 13:14 ` Jonathan Wakely
2015-04-09 11:17 ` Jonathan Wakely
2015-04-06 1:07 ` Hans-Peter Nilsson
2015-04-07 9:45 ` Jonathan Wakely
2015-04-07 10:52 ` Hans-Peter Nilsson
2015-04-07 13:12 ` Jonathan Wakely
2015-04-07 14:51 ` Hans-Peter Nilsson
2015-04-07 15:06 ` Jonathan Wakely
2015-04-08 3:58 ` Hans-Peter Nilsson
2015-04-08 9:35 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504130445.t3D4jZ24003363@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).