public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Yvan Roux <yvan.roux@linaro.org>
Cc: Vladimir Makarov <vmakarov@redhat.com>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: patch for PR65729
Date: Tue, 14 Apr 2015 08:11:00 -0000	[thread overview]
Message-ID: <20150414081123.GF1725@tucnak.redhat.com> (raw)
In-Reply-To: <CAD57uCezAGmX_ag9kaEdKLUEyLSzeDaFdBbfwgZWG6bZHo3P6w@mail.gmail.com>

On Tue, Apr 14, 2015 at 10:08:24AM +0200, Yvan Roux wrote:
> --- a/gcc/lra-constraints.c
> +++ b/gcc/lra-constraints.c
> @@ -1656,8 +1656,7 @@ prohibited_class_reg_set_mode_p (enum reg_class rclass,
>  {
>    HARD_REG_SET temp;
>    
> -  // ??? Is this assert right
> -  // lra_assert (hard_reg_set_subset_p (set, reg_class_contents[rclass]));
> +  lra_assert (hard_reg_set_subset_p (reg_class_contents[rclass],set));

Missing space after ,
Otherwise, I'll defer to Vlad for review.

	Jakub

  reply	other threads:[~2015-04-14  8:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 16:39 Vladimir Makarov
2015-04-14  8:08 ` Yvan Roux
2015-04-14  8:11   ` Jakub Jelinek [this message]
2015-04-14 15:36     ` Vladimir Makarov
2015-04-15 12:51       ` Yvan Roux
2015-04-18 14:22         ` Richard Earnshaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150414081123.GF1725@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=vmakarov@redhat.com \
    --cc=yvan.roux@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).