public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [Patch][testsuite,i386]: Remove include of values.h from avx512
@ 2015-04-15 16:30 Ryan Mansfield
  2015-04-16 14:55 ` Kirill Yukhin
  0 siblings, 1 reply; 2+ messages in thread
From: Ryan Mansfield @ 2015-04-15 16:30 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

Hi,

Some of the avx512 tests include values.h which is an obsolete header on 
Linux which provides compatibility macros based on limits.h and float.h 
definitions. On QNX we have no values.h ;), so these tests fail to 
build. The include doesn't appear to be needed on Linux, as 
x86_64-linux-gnu has no regressions with the include removed. I wasn't 
able to determine which target, if any, required values.h.

2015-04-15  Ryan Mansfield  <rmansfield@qnx.com>

         * gcc.target/i386/avx512bw-vpermi2w-2.c: Remove values.h include.
         * gcc.target/i386/avx512bw-vpermt2w-2.c: Ditto.
         * gcc.target/i386/avx512bw-vpmaddubsw-2.c: Ditto.
         * gcc.target/i386/avx512bw-vpmaddwd-2.c: Ditto.
         * gcc.target/i386/avx512dq-vfpclasspd-2.c: Ditto.
         * gcc.target/i386/avx512dq-vfpclassps-2.c: Dttto.
         * gcc.target/i386/avx512vbmi-vpermi2b-2.c: Ditto.
         * gcc.target/i386/avx512vbmi-vpermt2b-2.c: Ditto.

OK for trunk and gcc-5-branch?

Regards,

Ryan Mansfield
---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

[-- Attachment #2: novalues.diff --]
[-- Type: text/x-patch, Size: 3384 bytes --]

Index: gcc/testsuite/gcc.target/i386/avx512bw-vpermi2w-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/avx512bw-vpermi2w-2.c	(revision 222125)
+++ gcc/testsuite/gcc.target/i386/avx512bw-vpermi2w-2.c	(working copy)
@@ -7,7 +7,6 @@
 
 #define SIZE (AVX512F_LEN / 16)
 #include "math.h"
-#include "values.h"
 #include "avx512f-mask-type.h"
 
 #define NUM 32
Index: gcc/testsuite/gcc.target/i386/avx512bw-vpermt2w-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/avx512bw-vpermt2w-2.c	(revision 222125)
+++ gcc/testsuite/gcc.target/i386/avx512bw-vpermt2w-2.c	(working copy)
@@ -7,7 +7,6 @@
 
 #define SIZE (AVX512F_LEN / 16)
 #include "math.h"
-#include "values.h"
 #include "avx512f-mask-type.h"
 
 #define NUM 32
Index: gcc/testsuite/gcc.target/i386/avx512bw-vpmaddubsw-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/avx512bw-vpmaddubsw-2.c	(revision 222125)
+++ gcc/testsuite/gcc.target/i386/avx512bw-vpmaddubsw-2.c	(working copy)
@@ -6,7 +6,6 @@
 #include "avx512f-helper.h"
 
 #include <math.h>
-#include <values.h>
 #define SIZE (AVX512F_LEN / 16)
 #include "avx512f-mask-type.h"
 
Index: gcc/testsuite/gcc.target/i386/avx512bw-vpmaddwd-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/avx512bw-vpmaddwd-2.c	(revision 222125)
+++ gcc/testsuite/gcc.target/i386/avx512bw-vpmaddwd-2.c	(working copy)
@@ -6,7 +6,6 @@
 #include "avx512f-helper.h"
 
 #include <math.h>
-#include <values.h>
 #define SIZE (AVX512F_LEN / 32)
 #include "avx512f-mask-type.h"
 
Index: gcc/testsuite/gcc.target/i386/avx512dq-vfpclasspd-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/avx512dq-vfpclasspd-2.c	(revision 222125)
+++ gcc/testsuite/gcc.target/i386/avx512dq-vfpclasspd-2.c	(working copy)
@@ -6,7 +6,6 @@
 #include "avx512f-helper.h"
 
 #include <math.h>
-#include <values.h>
 #define SIZE (AVX512F_LEN / 64)
 #include "avx512f-mask-type.h"
 
Index: gcc/testsuite/gcc.target/i386/avx512dq-vfpclassps-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/avx512dq-vfpclassps-2.c	(revision 222125)
+++ gcc/testsuite/gcc.target/i386/avx512dq-vfpclassps-2.c	(working copy)
@@ -6,7 +6,6 @@
 #include "avx512f-helper.h"
 
 #include <math.h>
-#include <values.h>
 #include "avx512f-mask-type.h"
 #define SIZE (AVX512F_LEN / 32)
 
Index: gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c	(revision 222125)
+++ gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c	(working copy)
@@ -8,7 +8,6 @@
 
 #define SIZE (AVX512F_LEN / 8)
 #include "math.h"
-#include "values.h"
 #include "avx512f-mask-type.h"
 
 #define NUM 32
Index: gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c	(revision 222125)
+++ gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c	(working copy)
@@ -8,7 +8,6 @@
 
 #define SIZE (AVX512F_LEN / 8)
 #include "math.h"
-#include "values.h"
 #include "avx512f-mask-type.h"
 
 #define NUM 32

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch][testsuite,i386]: Remove include of values.h from avx512
  2015-04-15 16:30 [Patch][testsuite,i386]: Remove include of values.h from avx512 Ryan Mansfield
@ 2015-04-16 14:55 ` Kirill Yukhin
  0 siblings, 0 replies; 2+ messages in thread
From: Kirill Yukhin @ 2015-04-16 14:55 UTC (permalink / raw)
  To: Ryan Mansfield; +Cc: gcc-patches

Hello,

Thanks!

On 15 Apr 12:30, Ryan Mansfield wrote:
> OK for trunk and gcc-5-branch?
The patch is OK for trunk and gcc-5-branch (when it is open).

--
K

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-16 14:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-15 16:30 [Patch][testsuite,i386]: Remove include of values.h from avx512 Ryan Mansfield
2015-04-16 14:55 ` Kirill Yukhin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).