public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, jason@redhat.com
Subject: Re: [PATCH] Fix PR65549, avoid force_decl_die in late compilation
Date: Fri, 17 Apr 2015 10:39:00 -0000	[thread overview]
Message-ID: <20150417103907.GK1725@tucnak.redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1504171229240.6786@zhemvz.fhfr.qr>

On Fri, Apr 17, 2015 at 12:32:03PM +0200, Richard Biener wrote:
> So Jakub says that using comp_unit_die () for the context of the stub
> DIE is wrong and he is of course right.  The following adjusted patch
> uses the correct context, but only if we already have a DIE for it,
> otherwise we drop the DW_TAG_GNU_call_site ref on the floor.

I'd mention that this last line doesn't match what the code does,
because in reality it just means that we drop the DW_AT_abstract_origin
of DW_TAG_GNU_call_site.  That really means just that the debugger won't
know what function is called at that point, as if it were e.g.
an indirect jump with unknown target that is not preserved in any register
across the call), but e.g. all the guarantees that we cover all the calls
still holds.

	Jakub

  reply	other threads:[~2015-04-17 10:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17  9:05 Richard Biener
2015-04-17 10:32 ` Richard Biener
2015-04-17 10:39   ` Jakub Jelinek [this message]
2015-04-28  8:57     ` Richard Biener
2015-06-01 10:40       ` Richard Biener
2015-06-02 12:34   ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150417103907.GK1725@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).