From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8580 invoked by alias); 22 Apr 2015 11:12:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8563 invoked by uid 89); 22 Apr 2015 11:12:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 22 Apr 2015 11:12:09 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 6D1C93C214; Wed, 22 Apr 2015 11:12:08 +0000 (UTC) Received: from redhat.com (ovpn-204-27.brq.redhat.com [10.40.204.27]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3MBC3CI000597 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 22 Apr 2015 07:12:06 -0400 Date: Wed, 22 Apr 2015 11:12:00 -0000 From: Marek Polacek To: Manuel =?iso-8859-1?B?TPNwZXotSWLh8WV6?= Cc: Gcc Patch List Subject: Re: [C/C++ PATCH] Improve -Wlogical-op (PR c/63357) Message-ID: <20150422111203.GF28950@redhat.com> References: <20150421111638.GB28950@redhat.com> <55365C6E.1080100@gmail.com> <20150422085924.GE28950@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-04/txt/msg01285.txt.bz2 On Wed, Apr 22, 2015 at 11:50:17AM +0200, Manuel López-Ibáñez wrote: > So, I think your proposal is an improvement, however, it does not > fully fix the problem. For that, we need to have locations for the > operands of expressions (PR43486), so we can check if they are also > come from macro expansion. Right. Argh. I'll post that input.h bit nonetheless, it certainly won't make things worse... Thanks. Marek