From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57467 invoked by alias); 22 Apr 2015 20:46:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56685 invoked by uid 89); 22 Apr 2015 20:46:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Apr 2015 20:46:33 +0000 Received: from tsaunders-iceball.corp.tor1.mozilla.com (unknown [66.207.208.102]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id E1BF9C072; Wed, 22 Apr 2015 20:46:30 +0000 (UTC) Date: Wed, 22 Apr 2015 20:46:00 -0000 From: Trevor Saunders To: Jeff Law Cc: David Malcolm , tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 00/12] Reduce conditional compilation Message-ID: <20150422204622.GA21661@tsaunders-iceball.corp.tor1.mozilla.com> References: <1429622658-9034-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <5536573F.4090005@redhat.com> <20150421152914.GE9945@tsaunders-iceball.corp.tor1.mozilla.com> <1429726381.32584.146.camel@surprise> <5537EA4A.2010901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5537EA4A.2010901@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-04/txt/msg01362.txt.bz2 On Wed, Apr 22, 2015 at 12:36:58PM -0600, Jeff Law wrote: > On 04/22/2015 12:13 PM, David Malcolm wrote: > > > > >Conditional compilation was a major PITA when doing the rtx->rtx_insn * > >work last year, so I'm very pleased to see these cleanups go in. > Yup. It also got in Andrew's way last year and we regularly see cases where > small patches which work fine on the mainstream architectures fail to build > in the lesser used architectures (particularly cc0 targets). It's a whole > class of problems I want to see slowly disappear. yeah, its irritated me on a number of occasions too. I'd really like it if building config-list.mk could be faster, but that's a much bigger project, but at least if everything is target hooks maybe ccache can kick in some. Trev > > glibc went through this process in their codebase for similar reasons, but > they had more to lose when they got it wrong -- IIRC they had a case where > exported ABI would differ as a result of conditionally compiled code. Not > good. > > Jeff