From: Segher Boessenkool <segher@kernel.crashing.org>
To: Peter Bergner <bergner@vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Michael Meissner <meissner@linux.vnet.ibm.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state
Date: Fri, 24 Apr 2015 15:34:00 -0000 [thread overview]
Message-ID: <20150424153430.GA8212@gate.crashing.org> (raw)
In-Reply-To: <1429816564.21947.110.camel@otta>
On Thu, Apr 23, 2015 at 02:16:04PM -0500, Peter Bergner wrote:
> Ok, I created a separate ttest define_insn that hard codes the operands.
> I switched to using r1 rather than r0 as the second operand, for the
> reason that there could be code that sets r0 directly before this insn
> and I didn't want to create a unneeded read-after-write dependency.
> I thought r1 should be safe to use, since it's only updated in the
> prologue/epilogue and should be constant for the life of the function.
GPR1 is very likely already read before as well :-)
> > Maybe just { powerpc64 } works?
>
> powerpc64 doesn't work. It tells us whether the target will execute
> 64-bit instructions or not.
Ah yes, it is more like a "powerpc64_hw". Oh well.
All looks great to me now, thanks for the changes,
Segher
next prev parent reply other threads:[~2015-04-24 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 19:27 Peter Bergner
2015-03-20 20:52 ` Segher Boessenkool
2015-03-20 22:42 ` Peter Bergner
2015-04-21 20:56 ` Peter Bergner
2015-04-22 2:18 ` Segher Boessenkool
2015-04-22 13:43 ` Peter Bergner
2015-04-22 22:16 ` Segher Boessenkool
2015-04-22 23:08 ` Peter Bergner
2015-04-23 1:55 ` Segher Boessenkool
2015-04-23 3:17 ` Peter Bergner
2015-04-23 19:16 ` Peter Bergner
2015-04-24 15:34 ` Segher Boessenkool [this message]
2015-04-24 15:40 ` David Edelsohn
2015-04-27 15:21 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424153430.GA8212@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@vnet.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).