* Re: [PATCH] missing return in debug/vector _Safe_vector::operator=
[not found] <553F7DD6.7060407@redhat.com>
@ 2015-04-28 12:45 ` Jonathan Wakely
2015-04-28 12:47 ` Stephan Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Wakely @ 2015-04-28 12:45 UTC (permalink / raw)
To: Stephan Bergmann; +Cc: libstdc++, gcc-patches
[CCing gcc-patches]
On 28/04/15 14:32 +0200, Stephan Bergmann wrote:
>broken on GCC 5 and trunk
Ouch.
OK for trunk and the branch, do you have commit privs?
>Index: libstdc++-v3/ChangeLog
>===================================================================
>--- libstdc++-v3/ChangeLog (revision 222523)
>+++ libstdc++-v3/ChangeLog (working copy)
>@@ -1,3 +1,8 @@
>+2015-04-28 Stephan Bergmann <sbergman@redhat.com>
>+
>+ * include/debug/vector (__gnu_debug):
>+ Add missing return in _Safe_vector::operator=
>+
> 2015-04-28 Jonathan Wakely <jwakely@redhat.com>
>
> * libsupc++/exception (uncaught_exceptions): Add comment. Reorder #if.
>Index: libstdc++-v3/include/debug/vector
>===================================================================
>--- libstdc++-v3/include/debug/vector (revision 222523)
>+++ libstdc++-v3/include/debug/vector (working copy)
>@@ -69,7 +69,10 @@
>
> _Safe_vector&
> operator=(const _Safe_vector&) noexcept
>- { _M_update_guaranteed_capacity(); }
>+ {
>+ _M_update_guaranteed_capacity();
>+ return *this;
>+ }
>
> _Safe_vector&
> operator=(_Safe_vector&& __x) noexcept
>@@ -76,6 +79,7 @@
> {
> _M_update_guaranteed_capacity();
> __x._M_guaranteed_capacity = 0;
>+ return *this;
> }
> #endif
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] missing return in debug/vector _Safe_vector::operator=
2015-04-28 12:45 ` [PATCH] missing return in debug/vector _Safe_vector::operator= Jonathan Wakely
@ 2015-04-28 12:47 ` Stephan Bergmann
2015-04-28 12:59 ` Jonathan Wakely
0 siblings, 1 reply; 4+ messages in thread
From: Stephan Bergmann @ 2015-04-28 12:47 UTC (permalink / raw)
To: Jonathan Wakely; +Cc: libstdc++, gcc-patches
On 04/28/2015 02:38 PM, Jonathan Wakely wrote:
> [CCing gcc-patches]
>
> On 28/04/15 14:32 +0200, Stephan Bergmann wrote:
>> broken on GCC 5 and trunk
>
> Ouch.
>
> OK for trunk and the branch, do you have commit privs?
No, I don't; would be great if you can push that.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] missing return in debug/vector _Safe_vector::operator=
2015-04-28 12:47 ` Stephan Bergmann
@ 2015-04-28 12:59 ` Jonathan Wakely
2015-04-28 18:31 ` Jonathan Wakely
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Wakely @ 2015-04-28 12:59 UTC (permalink / raw)
To: Stephan Bergmann; +Cc: libstdc++, gcc-patches
On 28/04/15 14:43 +0200, Stephan Bergmann wrote:
>On 04/28/2015 02:38 PM, Jonathan Wakely wrote:
>>[CCing gcc-patches]
>>
>>On 28/04/15 14:32 +0200, Stephan Bergmann wrote:
>>>broken on GCC 5 and trunk
>>
>>Ouch.
>>
>>OK for trunk and the branch, do you have commit privs?
>
>No, I don't; would be great if you can push that.
Will do, thanks for the patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] missing return in debug/vector _Safe_vector::operator=
2015-04-28 12:59 ` Jonathan Wakely
@ 2015-04-28 18:31 ` Jonathan Wakely
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Wakely @ 2015-04-28 18:31 UTC (permalink / raw)
To: Stephan Bergmann; +Cc: libstdc++, gcc-patches
On 28/04/15 13:47 +0100, Jonathan Wakely wrote:
>On 28/04/15 14:43 +0200, Stephan Bergmann wrote:
>>On 04/28/2015 02:38 PM, Jonathan Wakely wrote:
>>>[CCing gcc-patches]
>>>
>>>On 28/04/15 14:32 +0200, Stephan Bergmann wrote:
>>>>broken on GCC 5 and trunk
>>>
>>>Ouch.
>>>
>>>OK for trunk and the branch, do you have commit privs?
>>
>>No, I don't; would be great if you can push that.
>
>Will do, thanks for the patch.
Committed to the trunk and gcc-5-branch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-28 17:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <553F7DD6.7060407@redhat.com>
2015-04-28 12:45 ` [PATCH] missing return in debug/vector _Safe_vector::operator= Jonathan Wakely
2015-04-28 12:47 ` Stephan Bergmann
2015-04-28 12:59 ` Jonathan Wakely
2015-04-28 18:31 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).